From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Kronos <kronos@people.it>
Cc: linux-fbdev-devel@lists.sourceforge.net,
benh@dreamland.darkstar.lan, benh@kernel.crashing.org
Subject: Re: [PATCH] radeonfb: fix init/exit section usage
Date: Fri, 07 Jan 2005 13:24:44 -0800 [thread overview]
Message-ID: <41DEFE1C.7010108@osdl.org> (raw)
In-Reply-To: <20050107215451.GA16507@dreamland.darkstar.lan>
Kronos wrote:
> Il Fri, Jan 07, 2005 at 11:28:07AM -0800, Randy.Dunlap ha scritto:
>
>>Fix 3 instances of calling exit section function from text or init:
>>Error: ./drivers/video/aty/radeon_base.o .text refers to 000029e5
>>R_386_PC32 .exit.text
>>Error: ./drivers/video/aty/radeon_base.o .text refers to 00002a60
>>R_386_PC32 .exit.text
>>Error: ./drivers/video/aty/radeon_base.o .init.text refers to 00000192
>>R_386_PC32 .exit.text
>>
>>Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
>>
>>diffstat:=
>> drivers/video/aty/radeon_base.c | 2 +-
>> 1 files changed, 1 insertion(+), 1 deletion(-)
>>
>>---
>
>
>>diff -Naurp ./drivers/video/aty/radeon_base.c~radeonfb_initexit ./drivers/video/aty/radeon_base.c
>>--- ./drivers/video/aty/radeon_base.c~radeonfb_initexit 2005-01-06 21:18:20.920585008 -0800
>>+++ ./drivers/video/aty/radeon_base.c 2005-01-07 10:30:16.661094480 -0800
>>@@ -261,7 +261,7 @@ static struct backlight_controller radeo
>>
>> #endif /* CONFIG_PPC_OF */
>>
>>-static void __devexit radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
>>+static void radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
>> {
>> if (!rinfo->bios_seg)
>> return;
>
>
> I see that radeon_unmap_ROM is called in radeonfb_pci_register (error
> path). Is this the problem?
Yes. It was called from radeon_map_ROM() [which is __init]
and from radeonfb_pci_register().
> Oh btw, the maintainer of the new radeonfb is Ben Herrenschmidt, not Ani
> Joshi.
OK, thanks for the info. Be nice if someone would update
MAINTAINERS with that info...
> Luca
--
~Randy
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
prev parent reply other threads:[~2005-01-07 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 19:28 [PATCH] radeonfb: fix init/exit section usage Randy.Dunlap
2005-01-07 21:54 ` Kronos
2005-01-07 21:24 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41DEFE1C.7010108@osdl.org \
--to=rddunlap@osdl.org \
--cc=benh@dreamland.darkstar.lan \
--cc=benh@kernel.crashing.org \
--cc=kronos@people.it \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).