From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dorcas AnonoLitunya <anonolitunya@gmail.com>
Cc: outreachy@lists.linux.dev, julia.lawall@inria.fr,
andi.shyti@linux.intel.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: sm750fb: Remove unused return value in program_mode_registers()
Date: Wed, 18 Oct 2023 12:34:36 +0300 [thread overview]
Message-ID: <41a6ac1b-d21e-41ab-b193-623d2f5f2d2c@kadam.mountain> (raw)
In-Reply-To: <492e63bbc58147fb534930ef9e1fb5d844ae8769.1697619623.git.anonolitunya@gmail.com>
On Wed, Oct 18, 2023 at 12:07:38PM +0300, Dorcas AnonoLitunya wrote:
> -static int program_mode_registers(struct mode_parameter *mode_param,
> - struct pll_value *pll)
> +static void program_mode_registers(struct mode_parameter *mode_param,
> + struct pll_value *pll)
> {
> int ret = 0;
> int cnt = 0;
> @@ -202,7 +202,6 @@ static int program_mode_registers(struct mode_parameter *mode_param,
> } else {
> ret = -1;
No need to set ret here.
> }
> - return ret;
> }
regards,
dan carpenter
next prev parent reply other threads:[~2023-10-18 9:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 9:07 [PATCH 0/2] Remove unused return values from functions Dorcas AnonoLitunya
2023-10-18 9:07 ` [PATCH 1/2] staging: sm750fb: Remove unused return value in display_control_adjust_sm750le() Dorcas AnonoLitunya
2023-10-18 9:07 ` [PATCH 2/2] staging: sm750fb: Remove unused return value in program_mode_registers() Dorcas AnonoLitunya
2023-10-18 9:26 ` Greg Kroah-Hartman
2023-10-18 9:34 ` Dorcas Litunya
2023-10-18 13:25 ` Greg Kroah-Hartman
2023-10-18 13:24 ` Dorcas Litunya
2023-10-18 9:34 ` Dan Carpenter [this message]
2023-10-18 12:06 ` Julia Lawall
2023-10-18 12:59 ` Dorcas Litunya
2023-10-18 13:15 ` Julia Lawall
2023-10-18 13:23 ` Greg Kroah-Hartman
2023-10-18 12:07 ` [PATCH 0/2] Remove unused return values from functions Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41a6ac1b-d21e-41ab-b193-623d2f5f2d2c@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=andi.shyti@linux.intel.com \
--cc=anonolitunya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox