Re: [patch resend] w100fb: Rewrite for platform independence

["Antonino A. Daplas" <adaplas@gmail.com>]

Richard Purdie wrote:
> The code w100fb was based on was horribly Sharp SL-C7x0 specific
> and there was little else that could be done as I had no access to
> anything else with a w100 in it. There is no real documentation 
> about this chipset available.
> 
> Ian Molton has access to other platforms with the w100 (Toshiba
> e-series) and so between us, we've improved w100fb and made it 
> platform independent. Ian Molton also added support for the 
> very similar w3220 and w3200 chipsets.
> 
> There are a lot of changes here and it nearly amounts to a rewrite 
> of the driver but it has been extensively tested and is being used 
> in preference to the original driver in the Zaurus community. I'd
> therefore like to update the mainline code to reflect this. 
> 
> [Comments from Antonino Daplas taken on board, thanks.]
> 
> Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Acked-by: Antonino Daplas <adaplas@pol.net>

> -		gSaveImagePtr[i] = NULL;
> +	if (par->extmem_active && par->saved_extmem) {
> +		memsize=par->mach->mem->size;
> +		memcpy(remapped_fbuf + (W100_FB_BASE-MEM_WINDOW_BASE), par->saved_extmem, memsize);

You missed converting this to memcpy_toio though.

Tony


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf