Re: Re: [PATCH] mach64 atari patch

["Antonino A. Daplas" <adaplas@gmail.com>]

James Simmons wrote:
> 
>> I'll also drop fbdev-dont-allow-softcursor-use-from-userland.patch as there
>> seems to be quite a bit of controversy there.
> 
> The disagreement was how much to change it at one time. Some patches where 
> just huge and did massive changes to all drivers. I wanted to break the patch 
> up into little pieces. Please apply this patch otherwise we will be stuck 
> where we are. 
> 

Please, my patch (based from Jon's) is huge because it's removing > 200 lines
and it's moving softcursor.c from drivers/video to drivers/video/console where
it belongs. But it is _not_ intrusive.  In fact, the majority of the patch consists
of a single logical change which removes the line below from each driver

- .fb_cursor = softcursor;

and removes the line below from drivers/video/Kconfig.

- select FB_SOFT_CURSOR

Our proposal aims to make complex code simpler and big code smaller. Your patch,
on the other hand, although small, introduces another flag  FB_HWCURSOR_SOFTCURSOR,
which is redundant, and adds yet another level of complexity to an already too
complex code.

I already have the patch, but I'm not pushing it yet because of an ongoing
disagreement, in courtesy to other developers such as yourself.

Tony


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf