Re: Re: [PATCH] mach64 atari patch

["Antonino A. Daplas" <adaplas@gmail.com>]

James Simmons wrote:
>>>> I just don't think this patch is as complex as you are making it out
>>>> to be. It is large simply because the same action has been repeated
>>>> for each of the 65 drivers. The action is only a simple deletion of
>>>> two lines.
>>> I'm not arguing over this. What is wrong with breaking this patch up!!!!!
>>> I still have no answer to this!!!! I'm using the hardware flag because
>>> sometimes the driver that does have a hardware cursor wants to turn
>>> support off for it.
>> Set  .fb_cursor = NULL; to turn off the support.
> 
> So forbid hardware drivers that support hware cursors to never turn off 
> there hardware cursor support!!!!!
> 
> Let see what drivers have a flag to control using the hardware cursor.
> 
> au1100fb	int nohwcursor
> intelfb		int hwcursor
> nvidia		int hwcur
> cyberfb
> 
> You need to remove this!!!!
>

Majority of the drivers that does support hardware cursors are written by myself.
If the driver does not want to turn on the hardware cursor, just return -ENODEV.
No need to fudge with pointers.

Tony 


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf