Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: "Alexander E. Patrakov" <patrakov@ums.usu.ru>,
	Richard Smith <smithbone@gmail.com>
Subject: Re: New driver: s3d2xfb
Date: Wed, 28 Sep 2005 21:16:06 +0800	[thread overview]
Message-ID: <433A9796.7000505@gmail.com> (raw)
In-Reply-To: <8a0c3678050928055020971433@mail.gmail.com>

Richard Smith wrote:
>>>       if (!cnt) {
>>>               save_s3(info);
>>>       }
> 
>> You don't need to enclose a single statement with "curly braces".
> 
> I'm not trying to start any kind of flameage here but my curiosity was
> just tweaked by that statement.
> 
> What do you like about single line if's over ones with {} that leads
> you to advocate their usage?  You've obviously got loads of experience
> with a large amount of code written by other people so I'm interested
> in your opinion.

I don't really care which way, but it's the preferred, albeit,
undocumented kernel coding style.

Tony


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

      reply	other threads:[~2005-09-28 13:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28 10:46 New driver: s3d2xfb Alexander E. Patrakov
2005-09-28 12:12 ` Antonino A. Daplas
2005-09-28 12:50   ` Richard Smith
2005-09-28 13:16     ` Antonino A. Daplas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=433A9796.7000505@gmail.com \
    --to=adaplas@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=patrakov@ums.usu.ru \
    --cc=smithbone@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox