linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Knut Petersen <Knut_Petersen@t-online.de>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH 1/1: 2.6.15-rc6] Fix clearing of vertical margins
Date: Tue, 20 Dec 2005 11:06:43 +0100	[thread overview]
Message-ID: <43A7D7B3.6000907@t-online.de> (raw)

Whenever the font width does not divide the x resolution, the remainder
of this division is a vertical margin at right of the screen. Whatever the
video memory contains in that margin is displayed.

This patch corrects this behaviour. There is no performance impact
as long as there is no vertical margin as fbcon_clear_margins() and
bit_clear_margins() only execute additional code if really necessary.

I think this patch should be applied before 2.6.15-final.

Signed-off-by: Knut Petersen <Knut_Petersen@t-online.de>

diff -uprN -X linux/Documentation/dontdiff -x '*.bak' -x '*.ctx' linuxorig/drivers/video/console/fbcon.c linux/drivers/video/console/fbcon.c
--- linuxorig/drivers/video/console/fbcon.c	2005-12-15 10:34:42.000000000 +0100
+++ linux/drivers/video/console/fbcon.c	2005-12-20 09:41:32.000000000 +0100
@@ -1399,7 +1399,7 @@ static __inline__ void ypan_up(struct vc
 	ops->var.yoffset = p->yscroll * vc->vc_font.height;
 	ops->var.vmode &= ~FB_VMODE_YWRAP;
 	ops->update_start(info);
-	fbcon_clear_margins(vc, 1);
+	fbcon_clear_margins(vc, 0);
 	scrollback_max += count;
 	if (scrollback_max > scrollback_phys_max)
 		scrollback_max = scrollback_phys_max;
@@ -1426,7 +1426,7 @@ static __inline__ void ypan_up_redraw(st
 	ops->var.yoffset = p->yscroll * vc->vc_font.height;
 	ops->var.vmode &= ~FB_VMODE_YWRAP;
 	ops->update_start(info);
-	fbcon_clear_margins(vc, 1);
+	fbcon_clear_margins(vc, 0);
 	scrollback_max += count;
 	if (scrollback_max > scrollback_phys_max)
 		scrollback_max = scrollback_phys_max;
@@ -1450,7 +1450,7 @@ static __inline__ void ypan_down(struct 
 	ops->var.yoffset = p->yscroll * vc->vc_font.height;
 	ops->var.vmode &= ~FB_VMODE_YWRAP;
 	ops->update_start(info);
-	fbcon_clear_margins(vc, 1);
+	fbcon_clear_margins(vc, 0);
 	scrollback_max -= count;
 	if (scrollback_max < 0)
 		scrollback_max = 0;
@@ -1477,7 +1477,7 @@ static __inline__ void ypan_down_redraw(
 	ops->var.yoffset = p->yscroll * vc->vc_font.height;
 	ops->var.vmode &= ~FB_VMODE_YWRAP;
 	ops->update_start(info);
-	fbcon_clear_margins(vc, 1);
+	fbcon_clear_margins(vc, 0);
 	scrollback_max -= count;
 	if (scrollback_max < 0)
 		scrollback_max = 0;




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

             reply	other threads:[~2005-12-20 10:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-20 10:06 Knut Petersen [this message]
2005-12-20 12:02 ` [PATCH 1/1: 2.6.15-rc6] Fix clearing of vertical margins Antonino A. Daplas
2005-12-21  5:48   ` Knut Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43A7D7B3.6000907@t-online.de \
    --to=knut_petersen@t-online.de \
    --cc=adaplas@gmail.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).