linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c
@ 2006-01-23 20:32 Kumba
  2006-01-23 23:53 ` Antonino A. Daplas
  0 siblings, 1 reply; 2+ messages in thread
From: Kumba @ 2006-01-23 20:32 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: linux-mips

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

Hi all,

Around line ~1247 in drivers/video/gbefb.c, gbefb_remove_sysfs uses the wrong parameter, causing an O2 kernel build 
to break when using this driver.  The attached patch supplies the correct parameter, allowing the build to succeed.


--Kumba


--
Gentoo/MIPS Team Lead
Gentoo Foundation Board of Trustees

"Such is oft the course of deeds that move the wheels of the world: small hands do them because they must, while the 
eyes of the great are elsewhere." --Elrond

[-- Attachment #2: misc-2.6.15-ip32-fix-another-gbefb-typo.patch --]
[-- Type: text/plain, Size: 535 bytes --]

diff -Naurp linux-2.6.15.1.orig/drivers/video/gbefb.c linux-2.6.15.1/drivers/video/gbefb.c
--- linux-2.6.15.1.orig/drivers/video/gbefb.c	2006-01-02 22:21:10.000000000 -0500
+++ linux-2.6.15.1/drivers/video/gbefb.c	2006-01-18 23:22:29.000000000 -0500
@@ -1244,7 +1244,7 @@ static int __devexit gbefb_remove(struct
 			  (void *)gbe_tiles.cpu, gbe_tiles.dma);
 	release_mem_region(GBE_BASE, sizeof(struct sgi_gbe));
 	iounmap(gbe);
-	gbefb_remove_sysfs(dev);
+	gbefb_remove_sysfs(&p_dev->dev);
 	framebuffer_release(info);
 
 	return 0;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c
  2006-01-23 20:32 [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c Kumba
@ 2006-01-23 23:53 ` Antonino A. Daplas
  0 siblings, 0 replies; 2+ messages in thread
From: Antonino A. Daplas @ 2006-01-23 23:53 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: linux-mips, kumba

Kumba wrote:
> Hi all,
> 
> Around line ~1247 in drivers/video/gbefb.c, gbefb_remove_sysfs uses the wrong parameter, causing an O2 kernel build 
> to break when using this driver.  The attached patch supplies the correct parameter, allowing the build to succeed.
> 

Okay.  Thanks.

Tony


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-01-23 23:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-23 20:32 [PATCH]: Fix SGI O2 Compile error in drivers/video/gbefb.c Kumba
2006-01-23 23:53 ` Antonino A. Daplas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).