From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: [PATCH 6/18] arcfb: Fix dereference before NULL check Date: Sat, 11 Mar 2006 09:49:55 +0800 Message-ID: <44122CC3.302@gmail.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1FHtNM-0002WA-2d for linux-fbdev-devel@lists.sourceforge.net; Fri, 10 Mar 2006 17:58:36 -0800 Received: from pproxy.gmail.com ([64.233.166.180]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1FHtNL-0003lQ-Q8 for linux-fbdev-devel@lists.sourceforge.net; Fri, 10 Mar 2006 17:58:36 -0800 Received: by pproxy.gmail.com with SMTP id z59so419612pyg for ; Fri, 10 Mar 2006 17:58:32 -0800 (PST) Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton Cc: Linux Fbdev development list , Jaya Kumar info->par is dereferenced before info is checked for NULL. Fix. Coverity Bug 833 Signed-off-by: Antonino Daplas --- drivers/video/arcfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c index 0cf26da..4660428 100644 --- a/drivers/video/arcfb.c +++ b/drivers/video/arcfb.c @@ -459,11 +459,11 @@ static ssize_t arcfb_write(struct file * inode = file->f_dentry->d_inode; fbidx = iminor(inode); info = registered_fb[fbidx]; - par = info->par; if (!info || !info->screen_base) return -ENODEV; + par = info->par; xres = info->var.xres; fbmemlength = (xres * info->var.yres)/8; ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642