Re: Bug in vga16fb?

["Antonino A. Daplas" <adaplas@gmail.com>]

Ondrej Zajicek wrote:
> On Thu, Apr 06, 2006 at 09:56:42PM +0800, Antonino A. Daplas wrote:
>> Ondrej Zajicek wrote:
>>> On Thu, Apr 06, 2006 at 12:48:48AM +0200, Petr Vandrovec wrote:
>>>> Ondrej Zajicek wrote:
>>> Even if we find some possibility to autodetect what hardware does (or in
>>> case of another, non-VGA hardware using CFB4 mode) there would be
>>> problem that driver cannot say it to userspace (or generic kernel
>>> functions like cfb_imageblit). Maybe there should be some flag in
>>> type_aux specifying whether given packed pixel mode is LSB-first or
>>> MSB-first (relevant only for bpp % 8 != 0) ?
>>>
>> var->{red|green|blue|transp}.msb_right
> 
> I think that this bit says something different - ordering of bits inside
> one color component. This is OK for all VGA (MSB bit of color index is
> left), i hope.
> 
> Problem is in ordering of pixels inside a byte, which is completely
> orthogonal to bitplane.msb_right-ness.
> 
> But maybe i misunderstood of meaning of 
> var->{red|green|blue|transp}.msb_right ...
> 
> 

I know, but since it is completely unused, you can use that to tell userspace
what the format is.  Or if you want something less specific, use var->nonstd.
Or if you want to standardize, add another FB_VISUAL_* entry.

Tony


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642