linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb
@ 2006-04-28 16:10 Dennis Munsie
  2006-04-29  0:05 ` Antonino A. Daplas
  0 siblings, 1 reply; 5+ messages in thread
From: Dennis Munsie @ 2006-04-28 16:10 UTC (permalink / raw)
  To: linux-fbdev-devel

From: Dennis Munsie <dmunsie@cecropia.com>

Adds 1366x768 @ 60Hz to drivers/video/modedb.c.

Signed-off-by: Dennis Munsie <dmunsie@cecropia.com>

---

  drivers/video/modedb.c |    6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

--- linux-2.6.16/drivers/video/modedb.c	2006-03-20 00:53:29.000000000  
-0500
+++ linux-2.6.16-wxga/drivers/video/modedb.c	2006-04-27  
17:08:11.000000000 -0500
@@ -255,7 +255,11 @@ static const struct fb_videomode modedb[
	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
	NULL, 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
-    },
+    }, {
+	/* 1366x768, 60 Hz, 47.403 kHz hsync, WXGA 16:9 aspect ratio */
+	NULL, 60, 1366, 768, 13806, 120, 10, 14, 3, 32, 5,
+	0, FB_VMODE_NONINTERLACED
+	},
};
#ifdef CONFIG_FB_MODE_HELPERS


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb
  2006-04-28 16:10 [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb Dennis Munsie
@ 2006-04-29  0:05 ` Antonino A. Daplas
  2006-04-29  1:31   ` Dennis Munsie
  0 siblings, 1 reply; 5+ messages in thread
From: Antonino A. Daplas @ 2006-04-29  0:05 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: dmunsie

Dennis Munsie wrote:
> From: Dennis Munsie <dmunsie@cecropia.com>
> 
> Adds 1366x768 @ 60Hz to drivers/video/modedb.c.
> 
> Signed-off-by: Dennis Munsie <dmunsie@cecropia.com>
> 
> ---
> 
>  drivers/video/modedb.c |    6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
> 
> --- linux-2.6.16/drivers/video/modedb.c    2006-03-20 00:53:29.000000000
> -0500
> +++ linux-2.6.16-wxga/drivers/video/modedb.c    2006-04-27
> 17:08:11.000000000 -0500
> @@ -255,7 +255,11 @@ static const struct fb_videomode modedb[
>     /* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
>     NULL, 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
>     FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
> -    },
> +    }, {
> +    /* 1366x768, 60 Hz, 47.403 kHz hsync, WXGA 16:9 aspect ratio */
> +    NULL, 60, 1366, 768, 13806, 120, 10, 14, 3, 32, 5,
> +    0, FB_VMODE_NONINTERLACED
> +    },
> };
> #ifdef CONFIG_FB_MODE_HELPERS
> 

Can you try first if any of these options will work for you:

video=xxxfb:1366x768M@60

or 

video=xxxfb:1366x768MR@60

Tony


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb
  2006-04-29  0:05 ` Antonino A. Daplas
@ 2006-04-29  1:31   ` Dennis Munsie
  2006-04-29  2:41     ` Antonino A. Daplas
  0 siblings, 1 reply; 5+ messages in thread
From: Dennis Munsie @ 2006-04-29  1:31 UTC (permalink / raw)
  To: linux-fbdev-devel

I'm away from the actual machine, but I did just try it blindly and  
checked out the output from the driver with dmesg:

fbcvt: Aspect ratio not CVT standard
fbcvt: 1360x768@60: CVT Name - Not a CVT standard - 1.044 Mega Pixel  
Image

intelfb: intelfb_check_var: accel_flags is 0
intelfb: intelfb_var_to_depth: bpp: 32, green.length is 0
intelfb: Initial video mode is 1366x768-32@59.

It looks as if something valid is coming back and the driver is  
setting up the mode, but at this point I don't know if there is  
really something on the display or not.  One thing that is  
disconcerting is that I asked for 60Hz and it returned back 59Hz.   
Another thing, which may be nothing, is that second line where it  
says the mode is 1360x768.  I am specifically requesting  
1366x768M-32@60 in for my modeline.

I will be able to test it more thoroughly on Monday when I am back in  
the office.

thanks!
dennis

On Apr 28, 2006, at 8:05 PM, Antonino A. Daplas wrote:

> Can you try first if any of these options will work for you:
>
> video=xxxfb:1366x768M@60
>
> or
>
> video=xxxfb:1366x768MR@60


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb
  2006-04-29  1:31   ` Dennis Munsie
@ 2006-04-29  2:41     ` Antonino A. Daplas
  2006-05-01 20:14       ` Dennis Munsie
  0 siblings, 1 reply; 5+ messages in thread
From: Antonino A. Daplas @ 2006-04-29  2:41 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: Dennis Munsie

Dennis Munsie wrote:
> I'm away from the actual machine, but I did just try it blindly and
> checked out the output from the driver with dmesg:
> 
> fbcvt: Aspect ratio not CVT standard
> fbcvt: 1360x768@60: CVT Name - Not a CVT standard - 1.044 Mega Pixel Image
> 
> intelfb: intelfb_check_var: accel_flags is 0
> intelfb: intelfb_var_to_depth: bpp: 32, green.length is 0
> intelfb: Initial video mode is 1366x768-32@59.
> 
> It looks as if something valid is coming back and the driver is setting
> up the mode, but at this point I don't know if there is really something
> on the display or not.  One thing that is disconcerting is that I asked
> for 60Hz and it returned back 59Hz.  Another thing, which may be
> nothing, is that second line where it says the mode is 1360x768.  I am
> specifically requesting 1366x768M-32@60 in for my modeline.

Ah, okay.  The CVT standard will always round off the horizontal resolution
to 8 pixels so 1360 from 1366.

> 
> I will be able to test it more thoroughly on Monday when I am back in
> the office.

Let me know if it works, but I'll still send your patch to mainline.

Tony
> 
> thanks!
> dennis
> 
> On Apr 28, 2006, at 8:05 PM, Antonino A. Daplas wrote:
> 
>> Can you try first if any of these options will work for you:
>>
>> video=xxxfb:1366x768M@60
>>
>> or
>>
>> video=xxxfb:1366x768MR@60
> 
> 
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Linux-fbdev-devel mailing list
> Linux-fbdev-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
> 



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb
  2006-04-29  2:41     ` Antonino A. Daplas
@ 2006-05-01 20:14       ` Dennis Munsie
  0 siblings, 0 replies; 5+ messages in thread
From: Dennis Munsie @ 2006-05-01 20:14 UTC (permalink / raw)
  To: linux-fbdev-devel

Just checked on the actual machine.  1366x768M-32@60 did not work at  
all -- the display is completely jumbled.  1366x768MR-32@60 seems to  
work, but I'm not entirely convinced.  The display looks a bit scaled  
at points, but fbset -i reports that it is indeed running at  
1366x768.  But, the other issue is that it's still reporting 59Hz  
instead of 60Hz.

Since it seems sketchy that the 1366x768 would continue to work since  
CVT specifies rounding off the pixels to multiples of 8, I think the  
best solution would be to put the modeline in the table.

dennis

On Apr 28, 2006, at 10:41 PM, Antonino A. Daplas wrote:

> Dennis Munsie wrote:
>> I'm away from the actual machine, but I did just try it blindly and
>> checked out the output from the driver with dmesg:
>>
>> fbcvt: Aspect ratio not CVT standard
>> fbcvt: 1360x768@60: CVT Name - Not a CVT standard - 1.044 Mega  
>> Pixel Image
>>
>> intelfb: intelfb_check_var: accel_flags is 0
>> intelfb: intelfb_var_to_depth: bpp: 32, green.length is 0
>> intelfb: Initial video mode is 1366x768-32@59.
>>
>> It looks as if something valid is coming back and the driver is  
>> setting
>> up the mode, but at this point I don't know if there is really  
>> something
>> on the display or not.  One thing that is disconcerting is that I  
>> asked
>> for 60Hz and it returned back 59Hz.  Another thing, which may be
>> nothing, is that second line where it says the mode is 1360x768.   
>> I am
>> specifically requesting 1366x768M-32@60 in for my modeline.
>
> Ah, okay.  The CVT standard will always round off the horizontal  
> resolution
> to 8 pixels so 1360 from 1366.
>
>>
>> I will be able to test it more thoroughly on Monday when I am back in
>> the office.
>
> Let me know if it works, but I'll still send your patch to mainline.
>
> Tony


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-05-01 20:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-28 16:10 [PATCH 2.6.16] Add 1366x768 (WXGA) mode to modedb Dennis Munsie
2006-04-29  0:05 ` Antonino A. Daplas
2006-04-29  1:31   ` Dennis Munsie
2006-04-29  2:41     ` Antonino A. Daplas
2006-05-01 20:14       ` Dennis Munsie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).