* [PATCH 5/5] backlight: Fix Kconfig dependency
@ 2006-05-28 0:42 Antonino A. Daplas
2006-05-28 6:23 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Antonino A. Daplas @ 2006-05-28 0:42 UTC (permalink / raw)
To: Andrew Morton
Cc: Linux Fbdev development list, Andrew Zabolotny, Richard Purdie
CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible
resulting in link errors. Fix by making backlight and lcd class also
depend on FB
Signed-off-by: Antonino Daplas <adaplas@pol.net>
---
drivers/video/backlight/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 02f1529..022f9d3 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT
config BACKLIGHT_CLASS_DEVICE
tristate "Lowlevel Backlight controls"
- depends on BACKLIGHT_LCD_SUPPORT
+ depends on BACKLIGHT_LCD_SUPPORT && FB
default m
help
This framework adds support for low-level control of the LCD
@@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE
config LCD_CLASS_DEVICE
tristate "Lowlevel LCD controls"
- depends on BACKLIGHT_LCD_SUPPORT
+ depends on BACKLIGHT_LCD_SUPPORT && FB
default m
help
This framework adds support for low-level control of LCD.
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 5/5] backlight: Fix Kconfig dependency
2006-05-28 0:42 [PATCH 5/5] backlight: Fix Kconfig dependency Antonino A. Daplas
@ 2006-05-28 6:23 ` Andrew Morton
2006-05-28 6:49 ` Antonino A. Daplas
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2006-05-28 6:23 UTC (permalink / raw)
To: Antonino A. Daplas; +Cc: linux-fbdev-devel, zap, rpurdie
On Sun, 28 May 2006 08:42:07 +0800
"Antonino A. Daplas" <adaplas@gmail.com> wrote:
> CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible
> resulting in link errors. Fix by making backlight and lcd class also
> depend on FB
>
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
> ---
>
> drivers/video/backlight/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 02f1529..022f9d3 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT
>
> config BACKLIGHT_CLASS_DEVICE
> tristate "Lowlevel Backlight controls"
> - depends on BACKLIGHT_LCD_SUPPORT
> + depends on BACKLIGHT_LCD_SUPPORT && FB
> default m
> help
> This framework adds support for low-level control of the LCD
> @@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE
>
> config LCD_CLASS_DEVICE
> tristate "Lowlevel LCD controls"
> - depends on BACKLIGHT_LCD_SUPPORT
> + depends on BACKLIGHT_LCD_SUPPORT && FB
> default m
> help
> This framework adds support for low-level control of LCD.
Would I be correct in believing that this is a mainline fix and hence
2.6.17 material?
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 5/5] backlight: Fix Kconfig dependency
2006-05-28 6:23 ` Andrew Morton
@ 2006-05-28 6:49 ` Antonino A. Daplas
0 siblings, 0 replies; 3+ messages in thread
From: Antonino A. Daplas @ 2006-05-28 6:49 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fbdev-devel, zap, rpurdie
Andrew Morton wrote:
> On Sun, 28 May 2006 08:42:07 +0800
> "Antonino A. Daplas" <adaplas@gmail.com> wrote:
>
>> CONFIG_FB = m and CONFIG_{BACKLIGHT:LCD}_CLASS_DEVICE = y is possible
>> resulting in link errors. Fix by making backlight and lcd class also
>> depend on FB
>>
>> Signed-off-by: Antonino Daplas <adaplas@pol.net>
>> ---
>>
>> drivers/video/backlight/Kconfig | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
>> index 02f1529..022f9d3 100644
>> --- a/drivers/video/backlight/Kconfig
>> +++ b/drivers/video/backlight/Kconfig
>> @@ -10,7 +10,7 @@ menuconfig BACKLIGHT_LCD_SUPPORT
>>
>> config BACKLIGHT_CLASS_DEVICE
>> tristate "Lowlevel Backlight controls"
>> - depends on BACKLIGHT_LCD_SUPPORT
>> + depends on BACKLIGHT_LCD_SUPPORT && FB
>> default m
>> help
>> This framework adds support for low-level control of the LCD
>> @@ -26,7 +26,7 @@ config BACKLIGHT_DEVICE
>>
>> config LCD_CLASS_DEVICE
>> tristate "Lowlevel LCD controls"
>> - depends on BACKLIGHT_LCD_SUPPORT
>> + depends on BACKLIGHT_LCD_SUPPORT && FB
>> default m
>> help
>> This framework adds support for low-level control of LCD.
>
> Would I be correct in believing that this is a mainline fix and hence
> 2.6.17 material?
>
It's mainline fix, though I would say that it's not urgent.
Tony
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-05-28 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-28 0:42 [PATCH 5/5] backlight: Fix Kconfig dependency Antonino A. Daplas
2006-05-28 6:23 ` Andrew Morton
2006-05-28 6:49 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).