Re: porting fb driver to 2, 6(fb_get_fix, fb_get_var)

["Antonino A. Daplas" <adaplas@gmail.com>]

syed khader wrote:
> 
> --- "Antonino A. Daplas" <adaplas@gmail.com> wrote:
> 
>> syed khader wrote:
>>> --- "Antonino A. Daplas" <adaplas@gmail.com>
>> wrote:
>>>> syed khader wrote:
>>
> Thanks for the inputs. Written as per your
> suggestions. I still have these questions:
> 1) The 2.4 driver code had fb_ioctl defined,
> apparently there is a user space application which
> uses these ioctls.(Basically these ioctls are used to
> set X and Y fontsizes and print at x and y
> coordinates)

If the 2.4 driver an xxxfb_ioctl() hook, then yes, you
can retain them practically unchanged.

(Just curious about the description of the ioctl, I don't
think you will need them for 2.6 as the driver should have
no concept of fontsizes)

> Shall I retain these ioctl OR does 2.6
> framebuffer has a different mechanism to do this?

You can retain driver-specific ioctls.

> 2) How can I know whether generic versions
> (cfb_imageblit & cfb_fillrect) will be sufficient OR  
> I should write specific to my LCD hardware.

If the framebuffer supports packed-pixel formats, then the
cfb_* drawing functions are sufficient.

In 2.4, if your driver is linked to fbcon-cfb*.c, then
you should be fine using the generic functions.

Tony