From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] add framebuffer and display update module support for pnx4008
Date: Fri, 30 Jun 2006 07:17:46 +0800 [thread overview]
Message-ID: <44A45F9A.2070207@gmail.com> (raw)
In-Reply-To: <20060628143006.f3d1b80a.vitalywool@gmail.com>
Vitaly Wool wrote:
> Hi folks,
>
> inlined is the updated version of the patch that adds support for
> Display Update Module and RGB framebuffer device on Philips PNX4008
> ARM board.
>
I did a final review before sending this to akpm, I noticed that in
put_cmd_string(), it is reading and writing to io memory but is not using
the standard IO accessors. Is this intended or an oversight?
If it's an oversight, would you prefer to fix it first, or should I post
it to akpm with the provision that it will be fixed later?
Tony
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-06-29 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 10:30 [PATCH] add framebuffer and display update module support for pnx4008 Vitaly Wool
2006-06-29 23:17 ` Antonino A. Daplas [this message]
2006-06-30 6:22 ` Vitaly Wool
-- strict thread matches above, loose matches on Subject: below --
2006-06-30 8:07 Vitaly Wool
2006-06-27 15:17 Vitaly Wool
2006-06-27 21:27 ` Antonino A. Daplas
2006-06-28 7:46 ` Vitaly Wool
2006-06-28 9:07 ` Antonino A. Daplas
2006-06-28 9:36 ` Vitaly Wool
2006-06-28 9:42 ` Geert Uytterhoeven
2006-06-27 13:16 Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A45F9A.2070207@gmail.com \
--to=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).