From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, gtolstolytkin@ru.mvista.com
Subject: Re: [PATCH 1/3] fbdev: Add framebuffer and display update module support for pnx4008
Date: Sat, 01 Jul 2006 13:03:43 +0800 [thread overview]
Message-ID: <44A6022F.30500@gmail.com> (raw)
In-Reply-To: <20060630204454.4ca27a23.akpm@osdl.org>
Andrew Morton wrote:
> On Fri, 30 Jun 2006 20:00:23 +0800
> "Antonino A. Daplas" <adaplas@gmail.com> wrote:
>
>> + if ((ret = put_cmd_string(cmds_c)) != 0) {
>> + return ret;
>> + }
>
> Guys, please avoid the assign-then-test trick. Kernel style is
> super-simple style. The above should be coded as:
>
I'm kinda lax when it comes to this style, but if you insist :-)
>
> ret = put_cmd_string(cmds_c);
> if (ret != 0)
> return ret;
>
> Nice and easy.
>
Tony
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2006-07-01 5:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 12:00 [PATCH 1/3] fbdev: Add framebuffer and display update module support for pnx4008 Antonino A. Daplas
2006-07-01 3:43 ` Andrew Morton
2006-07-01 5:02 ` Antonino A. Daplas
2006-07-01 5:11 ` Andrew Morton
2006-07-01 5:18 ` Antonino A. Daplas
2006-07-01 5:45 ` Andrew Morton
2006-07-01 8:25 ` Antonino A. Daplas
2006-07-01 3:44 ` Andrew Morton
2006-07-01 5:03 ` Antonino A. Daplas [this message]
2006-07-01 3:46 ` Andrew Morton
2006-07-01 5:02 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A6022F.30500@gmail.com \
--to=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=gtolstolytkin@ru.mvista.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).