From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Grigory Tolstolytkin <gtolstolytkin@ru.mvista.com>
Subject: Re: [PATCH] pnxrgbfb: Remove tty.h from #include
Date: Mon, 03 Jul 2006 07:19:40 +0800 [thread overview]
Message-ID: <44A8548C.5020902@gmail.com> (raw)
In-Reply-To: <acd2a5930607021056h85dbf20y2db8d6a1b8d12d1b@mail.gmail.com>
Vitaly Wool wrote:
> On 7/2/06, Antonino A. Daplas <adaplas@gmail.com> wrote:
>> Framebuffer drivers should have no dependencies on the tty layer.
>>
> <snip>
>> @@ -18,7 +18,6 @@ #include <linux/kernel.h>
>> #include <linux/errno.h>
>> #include <linux/string.h>
>> #include <linux/mm.h>
>> -#include <linux/tty.h>
>> #include <linux/slab.h>
>> #include <linux/vmalloc.h>
>> #include <linux/delay.h>
>
> Ok, agreed, thanks for pointing that out.
This actually depends on a just-recently submitted cleanup patch,
removing dependencies on tty and vt. So #include <linux/tty.h> was
the correct thing to do a few -mm versions ago :-)
Tony
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
prev parent reply other threads:[~2006-07-02 23:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-02 3:43 [PATCH] pnxrgbfb: Remove tty.h from #include Antonino A. Daplas
2006-07-02 17:56 ` Vitaly Wool
2006-07-02 23:19 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A8548C.5020902@gmail.com \
--to=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=gtolstolytkin@ru.mvista.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).