* [PATCH] pnxrgbfb: Remove tty.h from #include
@ 2006-07-02 3:43 Antonino A. Daplas
2006-07-02 17:56 ` Vitaly Wool
0 siblings, 1 reply; 3+ messages in thread
From: Antonino A. Daplas @ 2006-07-02 3:43 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Fbdev development list, Grigory Tolstolytkin
Framebuffer drivers should have no dependencies on the tty layer.
Signed-off-by: Antonino Daplas <adaplas@pol.net>
---
drivers/video/pnx4008/pnxrgbfb.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/pnx4008/pnxrgbfb.c b/drivers/video/pnx4008/pnxrgbfb.c
index 4bb7ad1..7d9453c 100644
--- a/drivers/video/pnx4008/pnxrgbfb.c
+++ b/drivers/video/pnx4008/pnxrgbfb.c
@@ -18,7 +18,6 @@ #include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/string.h>
#include <linux/mm.h>
-#include <linux/tty.h>
#include <linux/slab.h>
#include <linux/vmalloc.h>
#include <linux/delay.h>
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pnxrgbfb: Remove tty.h from #include
2006-07-02 3:43 [PATCH] pnxrgbfb: Remove tty.h from #include Antonino A. Daplas
@ 2006-07-02 17:56 ` Vitaly Wool
2006-07-02 23:19 ` Antonino A. Daplas
0 siblings, 1 reply; 3+ messages in thread
From: Vitaly Wool @ 2006-07-02 17:56 UTC (permalink / raw)
To: Antonino A. Daplas
Cc: Andrew Morton, Linux Fbdev development list, Grigory Tolstolytkin
On 7/2/06, Antonino A. Daplas <adaplas@gmail.com> wrote:
> Framebuffer drivers should have no dependencies on the tty layer.
>
<snip>
> @@ -18,7 +18,6 @@ #include <linux/kernel.h>
> #include <linux/errno.h>
> #include <linux/string.h>
> #include <linux/mm.h>
> -#include <linux/tty.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
> #include <linux/delay.h>
Ok, agreed, thanks for pointing that out.
Vitaly
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pnxrgbfb: Remove tty.h from #include
2006-07-02 17:56 ` Vitaly Wool
@ 2006-07-02 23:19 ` Antonino A. Daplas
0 siblings, 0 replies; 3+ messages in thread
From: Antonino A. Daplas @ 2006-07-02 23:19 UTC (permalink / raw)
To: Vitaly Wool
Cc: Andrew Morton, Linux Fbdev development list, Grigory Tolstolytkin
Vitaly Wool wrote:
> On 7/2/06, Antonino A. Daplas <adaplas@gmail.com> wrote:
>> Framebuffer drivers should have no dependencies on the tty layer.
>>
> <snip>
>> @@ -18,7 +18,6 @@ #include <linux/kernel.h>
>> #include <linux/errno.h>
>> #include <linux/string.h>
>> #include <linux/mm.h>
>> -#include <linux/tty.h>
>> #include <linux/slab.h>
>> #include <linux/vmalloc.h>
>> #include <linux/delay.h>
>
> Ok, agreed, thanks for pointing that out.
This actually depends on a just-recently submitted cleanup patch,
removing dependencies on tty and vt. So #include <linux/tty.h> was
the correct thing to do a few -mm versions ago :-)
Tony
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-02 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-02 3:43 [PATCH] pnxrgbfb: Remove tty.h from #include Antonino A. Daplas
2006-07-02 17:56 ` Vitaly Wool
2006-07-02 23:19 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).