Re: [PATCH]: frame buffer driver for 2700G LCD controller

[Mike Rapoport <mike@compulab.co.il>]

Antonino A. Daplas wrote:

>Mike Rapoport wrote:
>  
>
>>Antonino A. Daplas wrote:
>>
>>    
>>
>>>Mike Rapoport wrote:
>>> 
>>>
>>>      
>>>
>>>>This patch adds frame buffer driver for 2700G LCD controller present on
>>>>CompuLab CM-X270 computer module.
>>>>This pacth is versus current Linus git tree.
>>>>
>>>>Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>>>>
>>>>
>>>>        
>>>>
>>+/* extern unsigned long virt_base_2700; */
>>+#define __REG_2700G(x)	(*(volatile unsigned long*)((x)+virt_base_2700))
>>    
>>
>
>BTW, you will need to use generic accessors (readb|w|l, writeb|w|l or
>__raw_readb|w|l, __raw_writeb|w|l, etc). This will entail a lot of changes.
>Otherwise, this driver won't get past Andrew Morton and Rusty.
>
>See include/asm/io.h.
>  
>
What's the better way?
{
    ...
    writel((readl(REG) | bits), REG);
    ...
}

or

{
    ...
    u32 some_reg = readl(REG);
    ...
    some_reg |= bits;
    ...
    writel(some_reg, REG)
    ...
}

>Tony
>
>
>
>
>  
>


-- 
Sincerely yours,
Mike Rapoport



-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642