From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Bernhard Fischer <yght@users.sourceforge.net>
Cc: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH]: frame buffer driver for 2700G LCD controller
Date: Tue, 11 Jul 2006 21:46:47 +0800 [thread overview]
Message-ID: <44B3ABC7.4070100@gmail.com> (raw)
In-Reply-To: <20060711132402.GB1533@aon.at>
Bernhard Fischer wrote:
> Could some kind soul do a recursive s/timming/timing/g in
> drivers/video, please? TIA.
>
>
> IIRC it was already stated that it is better to only set the .suspend
> and .resume ops depending on CONFIG_PM (see below instead of the #if
> #else #endif stanza here).
>> +#else
>> +#define mbxfb_suspend NULL
>> +#define mbxfb_resume NULL
>> +#endif
>
No, this is preferred. If possible, we want to avoid ifdef's within
functions or structures.
Tony
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
prev parent reply other threads:[~2006-07-11 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 15:25 [PATCH]: frame buffer driver for 2700G LCD controller Mike Rapoport
2006-07-07 2:19 ` Antonino A. Daplas
2006-07-09 14:40 ` Mike Rapoport
2006-07-09 19:38 ` Geert Uytterhoeven
2006-07-09 23:21 ` Antonino A. Daplas
2006-07-11 10:08 ` Mike Rapoport
2006-07-11 9:33 ` Antonino A. Daplas
2006-07-11 12:10 ` Mike Rapoport
2006-07-11 12:53 ` Antonino A. Daplas
2006-07-11 14:14 ` Mike Rapoport
2006-07-11 13:24 ` Bernhard Fischer
2006-07-11 13:46 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B3ABC7.4070100@gmail.com \
--to=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=yght@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).