linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Helt" <krzysztof.h1@wp.pl>
To: linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	linux-fbdev-devel@lists.sourceforge.net
Subject: RFC: s3c2410fb direction of changes.
Date: Tue, 09 Jan 2007 08:08:17 +0100	[thread overview]
Message-ID: <45a33f611aa47@wp.pl> (raw)

Hello,

There is a clash between sent patches 4067/1 and 4083/1. 

The patch 4083 comes into a direction of complete removal of the
fb registers from the s3c2410fb structure.

The patch 4067 comes in the opposite direction as #4083/1. It
depends whether you want complete removal of the s3c2410fb
registers settings and do everything by settings separate fields
(e.g. display type instead of 2-bits of in the lcdcon1).

IMO, the best way is the same as the PXA display is set:
registers calculated from other values (e.g. from resolution,
bpp, etc) should be removed from the s3c2410fb definition and
calculated by the framebuffer code. The enum type values (e.g.
the display type) should be set with "or" operator into registers
where they belong to. Look at the pxafb_mach_info structure.

Which direction is bettter?

Regards,
Krzysztof

----------------------------------------------------
LUC BESSON przedstawia
Najwiêksz± europejsk± animacjê ostatnich lat!!
ARTUR I MINIMKI - ju¿ w kinach!!
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fminimki.html&sid=984



-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

                 reply	other threads:[~2007-01-09  7:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45a33f611aa47@wp.pl \
    --to=krzysztof.h1@wp.pl \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).