RFC: s3c2410fb direction of changes.

RFC: s3c2410fb direction of changes.

[Krzysztof Helt]

Hello,

There is a clash between sent patches 4067/1 and 4083/1. 

The patch 4083 comes into a direction of complete removal of the
fb registers from the s3c2410fb structure.

The patch 4067 comes in the opposite direction as #4083/1. It
depends whether you want complete removal of the s3c2410fb
registers settings and do everything by settings separate fields
(e.g. display type instead of 2-bits of in the lcdcon1).

IMO, the best way is the same as the PXA display is set:
registers calculated from other values (e.g. from resolution,
bpp, etc) should be removed from the s3c2410fb definition and
calculated by the framebuffer code. The enum type values (e.g.
the display type) should be set with "or" operator into registers
where they belong to. Look at the pxafb_mach_info structure.

Which direction is bettter?

Regards,
Krzysztof

----------------------------------------------------
LUC BESSON przedstawia
Najwiêksz± europejsk± animacjê ostatnich lat!!
ARTUR I MINIMKI - ju¿ w kinach!!
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fminimki.html&sid=984



-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php