Re: [PATCH] [FB] Add the carmine FB driver.

["Jaya Kumar" <jayakumar.lkml@gmail.com>]

On Fri, Apr 18, 2008 at 1:28 PM, Sebastian Siewior
<frame+buffer@ml.breakpoint.cc> wrote:
>  +#ifndef MODULE
>  +static int __init carminefb_setup(void)
>  +{
>  +       char *options;
>  +
>  +       if (fb_get_options("carmine", &options))
>  +               return -ENXIO;

Hi Sebastian,

Interesting work. btw, I think there was some discussion of
deprecating the fb_get_options and associated manual parsing code in
favor of using module.option = value. Since this is a new driver, is
there an advantage in keeping the legacy option support?

>  +
>  +               if (!strncmp(this_opt, "mode:", 5))
>  +                       carminefb_mode = simple_strtoul(this_opt + 5, NULL, 0);

checkpatch suggests using strict_strtoul.

Thanks,
jaya

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone