Re: [RFC 2.6.26-rc3 0/5] am200epd, pxafb, metronomefb changes v2

["Jaya Kumar" <jayakumar.lkml@gmail.com>]

On Sat, May 31, 2008 at 2:41 AM, Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> Also, if the am200epd changes are less then say 40% of the original
> driver I would prefer to see an incremental patch, not replacement of
> the driver as it is not clear what was changed.
>

Agreed. If I look at the changes manually:

$ wc -l /home/jaya/kernelwork/mainline/linux-2.6/drivers/video/am200epd.c
295 /home/jaya/kernelwork/mainline/linux-2.6/drivers/video/am200epd.c

$ diff -Naur /home/jaya/kernelwork/mainline/linux-2.6/drivers/video/am200epd.c
arch/arm/mach-pxa/am200epd.c | diffstat
 am200epd.c |  346 +++++++++++++++++++++++++++++++++++--------------------------
 1 file changed, 199 insertions(+), 147 deletions(-)

It feels like a full replacement. I couldn't figure out how to do an
incremental patch because the original version is
drivers/video/am200epd.c which uses raw LCDC register writes (which is
no longer compatible because of the regs changes from pxafb) whereas
the new version is arch/arm/mach-pxa/am200epd.c which hooks into pxafb
and does not touch LCDC registers.

Thanks,
jaya

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/