Re: [PATCH 1/4] video: fbdev: pxafb: clear allocated memory for video modes

Daniel Mack
2018-07-09T05:12:50Z

Hi Bartlomiej,

Should I resend with Robert's Reviewed-bys again? I'd like to get this
merged for 4.19 if possible.

Thanks,
Daniel

On Sunday, June 24, 2018 05:38 PM, Daniel Mack wrote:
> When parsing the video modes from DT properties, make sure to zero out
> memory before using it. This is important because not all fields in the mode
> struct are explicitly initialized, even though they are used later on.
>
> Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion)
> Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
> drivers/video/fbdev/pxafb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 76722a59f55e..dfe382e68287 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2128,8 +2128,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp,
> return -EINVAL;
>
> ret = -ENOMEM;
> - info->modes = kmalloc_array(timings->num_timings,
> - sizeof(info->modes[0]), GFP_KERNEL);
> + info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]),
> + GFP_KERNEL);
> if (!info->modes)
> goto out;
> info->num_modes = timings->num_timings;
>