linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Krzysztof Helt" <krzysztof.h1@wp.pl>
To: linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>
Subject: [PATCH] pm2fb: Fix of jumps in pm2fb_probe
Date: Fri, 04 May 2007 19:15:00 +0200	[thread overview]
Message-ID: <463b6a1411340@wp.pl> (raw)

[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]

From: Krzysztof Helt <krzysztof.h1@wp.pl>

This patch fixes incorrect targets of jumps when an error occurs 
in the pm2fb_probe.

Signed-off-by: <krzysztof.h1@wp.pl>

---

This patch may requires pm2fb patches I sent before.



--- linux-2.6.21.orig/drivers/video/pm2fb.c	2007-05-03 14:46:
06.000000000 +0200
+++ linux-2.6.21/drivers/video/pm2fb.c	2007-05-03 14:46:59.
000000000 +0200
@@ -1210,10 +1209,10 @@ static int __devinit pm2fb_probe(struct 
 		info->var = pm2fb_var;
 
 	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
-		goto err_exit_all;
+		goto err_exit_both;
 
 	if (register_framebuffer(info) < 0)
-		goto err_exit_both;
+		goto err_exit_all;
 
 	printk(KERN_INFO "fb%d: %s frame buffer device, memory = %
dK.\n",
 	       info->node, info->fix.id, pm2fb_fix.smem_len / 1024);


----------------------------------------------------
Zobacz, jaką walkę stoczy superbohater, by ocalić siebie
i swych bliskich. A największa bitwa rozegra się w jego duszy.
SPIDER-MAN 3 w kinach od 4 maja.
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fspiderman3.html&sid=1122

[-- Attachment #2: pm2fb-exit-fix.diff --]
[-- Type: application/octet-stream, Size: 557 bytes --]

--- linux-2.6.21.orig/drivers/video/pm2fb.c	2007-05-03 14:46:06.000000000 +0200
+++ linux-2.6.21/drivers/video/pm2fb.c	2007-05-03 14:46:59.000000000 +0200
@@ -1210,10 +1209,10 @@ static int __devinit pm2fb_probe(struct 
 		info->var = pm2fb_var;
 
 	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
-		goto err_exit_all;
+		goto err_exit_both;
 
 	if (register_framebuffer(info) < 0)
-		goto err_exit_both;
+		goto err_exit_all;
 
 	printk(KERN_INFO "fb%d: %s frame buffer device, memory = %dK.\n",
 	       info->node, info->fix.id, pm2fb_fix.smem_len / 1024);

[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

                 reply	other threads:[~2007-05-04 17:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=463b6a1411340@wp.pl \
    --to=krzysztof.h1@wp.pl \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).