From: Geoff Levand <geoffrey.levand@am.sony.com>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Linux/PPC Development <linuxppc-dev@ozlabs.org>,
linux-fbdev-devel@lists.sourceforge.net,
Paul Mackerras <paulus@samba.org>
Subject: Re: [Linux-fbdev-devel] [patch 17/18] PS3: Frame buffer system-bus rework
Date: Wed, 06 Jun 2007 16:08:07 -0700 [thread overview]
Message-ID: <46673E57.3020009@am.sony.com> (raw)
In-Reply-To: <1181145418.5023.11.camel@daplas>
Hi.
Antonino A. Daplas wrote:
> On Wed, 2007-06-06 at 08:51 +0200, Geert Uytterhoeven wrote:
>> This one should go through linux-fbdev-devel (CC) for review, but Paul can
>> merge it because it depends on the PS3 system bus device rework.
>>
>
>> >
>> > -static void ps3fb_shutdown(struct platform_device *dev)
>> > +static int __devexit ps3fb_remove(struct ps3_system_bus_device *dev)
>> > {
>> > - ps3fb_flip_ctl(0); /* flip off */
>> > - ps3fb.dinfo->irq.mask = 0;
>> > - free_irq(ps3fb.irq_no, ps3fb.dev);
>> > - ps3_irq_plug_destroy(ps3fb.irq_no);
>> > - iounmap((u8 __iomem *)ps3fb.dinfo);
>> > + BUG();
>
> Why BUG()?
remove() doesn't work because lack of support from fbcon. I'll remove
this though, since it independent of the fbcon fix.
-Geoff
next prev parent reply other threads:[~2007-06-06 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070606024407.786638029@am.sony.com>
[not found] ` <46662399.7030401@am.sony.com>
2007-06-06 6:51 ` [patch 17/18] PS3: Frame buffer system-bus rework Geert Uytterhoeven
2007-06-06 15:56 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-06-06 23:08 ` Geoff Levand [this message]
2007-06-06 23:37 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46673E57.3020009@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=adaplas@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).