From: Krzysztof Helt This patch contains 3 small improvements: - it corrects scan line width calculation in pm3fb_imageblit() - it corrects mmio mapping for big endian machines - it enables panning acceleration constants Signed-off-by: Krzysztof Helt --- I have no big endian machine to check but the bug is obvious. I hope that someone with the big endian machine could check this driver. --- linux-2.6.21.old/drivers/video/pm3fb.c 2007-06-14 06:20:20.981188087 +0200 +++ linux-2.6.21/drivers/video/pm3fb.c 2007-06-13 23:36:49.533883967 +0200 @@ -558,7 +558,8 @@ static void pm3fb_imageblit(struct fb_in while (height--) { - int width = ((image->width + 7) >> 3) + info->pixmap.scan_align; + int width = ((image->width + 7) >> 3) + + info->pixmap.scan_align - 1; width >>= 2; while (width >= PM3_FIFO_SIZE) { @@ -1195,6 +1196,10 @@ static int __devinit pm3fb_probe(struct */ pm3fb_fix.mmio_start = pci_resource_start(dev, 0); pm3fb_fix.mmio_len = PM3_REGS_SIZE; +#if defined(__BIG_ENDIAN) + pm3fb_fix.mmio_start += PM3_REGS_SIZE; + DPRINTK("Adjusting register base for big-endian.\n"); +#endif /* Registers - request region and map it. */ if (!request_mem_region(pm3fb_fix.mmio_start, pm3fb_fix.mmio_len, @@ -1211,10 +1216,6 @@ static int __devinit pm3fb_probe(struct goto err_exit_neither; } -#if defined(__BIG_ENDIAN) - pm3fb_fix.mmio_start += PM3_REGS_SIZE; - DPRINTK("Adjusting register base for big-endian.\n"); -#endif /* Linear frame buffer - request region and map it. */ pm3fb_fix.smem_start = pci_resource_start(dev, 1); pm3fb_fix.smem_len = pm3fb_size_memory(par); @@ -1244,7 +1245,8 @@ static int __devinit pm3fb_probe(struct info->fix = pm3fb_fix; info->pseudo_palette = par->palette; info->flags = FBINFO_DEFAULT | -/* FBINFO_HWACCEL_YPAN |*/ + FBINFO_HWACCEL_XPAN | + FBINFO_HWACCEL_YPAN | FBINFO_HWACCEL_COPYAREA | FBINFO_HWACCEL_IMAGEBLIT | FBINFO_HWACCEL_FILLRECT;