Re: [PATCH] pxafb: Add support for other palette formats

[Paulo Marques <pmarques@grupopie.com>]

Hans-Jürgen Koch wrote:
> Am Dienstag 03 Juli 2007 16:46 schrieb Paulo Marques:
>> [...]
>> I've been working on getting the non-palletized 18bpp modes working and 
>> had a preliminar patch that just didn't support packed mode yet (using 
>> 24 bits per pixel).
> 
> Can userspace applications work with such a weired format?
> If yes, I'm looking forward to your patch.

It is not really that weird: rgb is packed 6 bits per component into 18 
bits. Those 18 bits will then occupy the lower bits of a 24 bit value or 
a 32 bit value depending on using packed or unpacked mode.

I'm doing this for the OpenEZX project to handle some motorola phones 
that have 18bpp support.

Motorola uses this mode in their software, so I suppose Qt already 
supports it.

Nevertheless, it seems a really big waste to have such a colorful 
display and then just use a palletized frame-buffer :P

So, if there are some userspace applications not supporting this mode, 
we should address them, but the support has to be in the kernel first... :(

>> We can either apply this patch as is and I'll just merge my work later, 
>> or I can try to merge both patches and send a single patch upstream. 
>> Either way is fine by me.
> 
> It's probably cleaner to merge two small patches than a big one.

Ok. It is also less stressful for me, too ;)

-- 
Paulo Marques - www.grupopie.com

"All I ask is a chance to prove that money can't make me happy."

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/