From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Date: Mon, 19 Feb 2018 09:56:04 +0000 Subject: Re: [RESEND PATCH v5 2/5] dt-bindings: pwm-backlight: add PWM delay proprieties. Message-Id: <4692672.MjQUXlf6O3@phil> List-Id: References: <20180216174034.15936-1-enric.balletbo@collabora.com> <20180216174034.15936-2-enric.balletbo@collabora.com> <20180219092247.estv4d2v6cbopx6z@dell> In-Reply-To: <20180219092247.estv4d2v6cbopx6z@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Thompson , Bartlomiej Zolnierkiewicz , Jingoo Han , linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Thierry Reding , Jacek Anaszewski , Pavel Machek , Enric Balletbo i Serra , Richard Purdie , kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org Hi Lee, Am Montag, 19. Februar 2018, 10:22:47 CET schrieb Lee Jones: > On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote: > > > Hardware needs a delay between setting an initial (non-zero) PWM and > > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > > this delay in milli seconds. Hardware also needs a delay between disabing > > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > > is this delay in milli seconds. > > > > Signed-off-by: Enric Balletbo i Serra > > Acked-by: Pavel Machek > > --- > > Based on the original Huang Lin work. > > > > Changes since v4: > > - Rebase on top of mainline. > > Changes since v3: > > - Replace us for ms. > > - Add Acked-by: Pavel Machek > > Changes since v2: > > - Use separate properties (Rob Herring) > > Changes since v1: > > - As suggested by Daniel Thompson > > - Do not assume power-on delay and power-off delay will be the same > > > > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Looks like this still needs an Ack. > > Also, you didn't supply a 0th (cover-letter) patch, so I have no idea > of patch history or your future intentions. > > Are there build-time dependencies between them or can each patch be > merged via their respective trees without the fear of merge/build > failure? When looking at the patches, there do not seem to be any build-time dependencies between the patch 1-3 (backlight) and 4+5 devicetree, so after Rob hopefully has time to look at the binding change, I'd suspect you take the code changes and I'll take the dts changes. Heiko