From: Tim Tassonis <timtas@cubic.ch>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Krzysztof Halasa <khc@pm.waw.pl>, Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
ak@suse.de, adaplas@gmail.com,
linux-fbdev-devel@lists.sourceforge.net,
benh@kernel.crashing.org
Subject: Re: [git patches] two warning fixes
Date: Fri, 20 Jul 2007 14:54:03 +0200 [thread overview]
Message-ID: <46A0B06B.3060701@cubic.ch> (raw)
In-Reply-To: <alpine.LFD.0.999.0707191056010.27353@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> I think "must_check" is an abomination. It makes the callee dictate what
> the caller has to do, but dammit, if the callee really "knows" its errors
> are that serious, it should damn well handle them itself.
>
> The whole "sysfs_create_file()" thing is an example of that. If it fails,
> it fails. The caller can't do anythign about it anyway, except perhaps
> print a message. Why the hell does such a function have the "right" to
> dictate what the user should do?
Well, that's just how OO fascists think. An object dictates to the user
what he/she can do with it, as opposed to the user can do what he
wants/needs.
Tim
prev parent reply other threads:[~2007-07-20 12:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 23:55 [git patches] two warning fixes Jeff Garzik
2007-07-18 23:59 ` Andi Kleen
2007-07-19 0:05 ` Jeff Garzik
2007-07-19 1:19 ` Benjamin Herrenschmidt
2007-07-19 1:41 ` Andrew Morton
2007-07-19 1:50 ` Linus Torvalds
2007-07-19 2:05 ` Benjamin Herrenschmidt
2007-07-19 2:36 ` Andrew Morton
2007-07-19 1:37 ` Linus Torvalds
2007-07-19 2:32 ` Jeff Garzik
2007-07-19 13:40 ` Krzysztof Halasa
2007-07-19 18:04 ` Linus Torvalds
2007-07-19 18:20 ` Stephen Hemminger
2007-07-20 18:34 ` Krzysztof Halasa
2007-07-21 0:32 ` Benjamin Herrenschmidt
2007-07-22 4:03 ` Jeff Garzik
2007-07-22 21:29 ` Benjamin Herrenschmidt
2007-07-23 3:26 ` Kyle Moffett
2007-07-19 13:38 ` Krzysztof Halasa
2007-07-19 18:00 ` Linus Torvalds
2007-07-20 12:54 ` Tim Tassonis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A0B06B.3060701@cubic.ch \
--to=timtas@cubic.ch \
--cc=adaplas@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).