Re: [PATCH 11/20] cirrusfb: checkpatch.plcleanup

["Krzysztof Helt" <krzysztof.h1@wp.pl>]

Dnia 27-08-2007 o godz. 9:15 Geert Uytterhoeven napisa³:
> >  drivers/video/cirrusfb.c | 1788
+++++++++++++++++++++++++---------------------
> >  1 files changed, 983 insertions(+), 805 deletions(-)
> > 
> > diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
> > index 8269d70..4c97c1d 100644
> > --- a/drivers/video/cirrusfb.c
> > +++ b/drivers/video/cirrusfb.c
> > @@ -59,7 +59,7 @@ #include <asm/amigahw.h>
> >  #endif
> >  #ifdef CONFIG_PPC_PREP
> >  #include <asm/machdep.h>
> > -#define isPReP (machine_is(prep))
> > +#define isPReP(machine_is(prep))
> >  #else
> >  #define isPReP 0
> >  #endif
> 
> This chunk is bogus. Probably there should be a tab instead of
a space to
> silence checkpatch, or checkpatch should become smarter...
> 

My bad. The simplest solution is to drop parentheses so it becomes

#define isPReP machine_is(prep)

I'll made a patch today (about 12 hours later) if someone does
not make it earlier.

Regards,
Krzysztof

----------------------------------------------------
Wspó³czesna bajka dla doros³ych! Zmys³owe opisy, magiczne 
zdarzenia, ironiczne komentarze "Mam ³ózko z racuchów 
na ma¶lance" Jaclyn Moriarty ju¿ w ksiegaranich! 
http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fracuchy.html&sid=2



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/