From: "H. Peter Anvin" <hpa@zytor.com>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, tibor.osztodi@bbraun.com,
linux-info@geode.amd.com
Subject: Re: [PATCH] [LXFB] Use the correct MSR number for panel support
Date: Mon, 29 Oct 2007 17:02:56 -0700 [thread overview]
Message-ID: <472674B0.9080001@zytor.com> (raw)
In-Reply-To: <20071026145301.14168.19412.stgit@cosmic.amd.com>
Jordan Crouse wrote:
> From: Jordan Crouse <jordan.crouse@amd.com>
>
> A relatively recent version of the Geode LX datasheet listed the wrong
> address for one of the MSRs that controls TFT panels, resulting in
> breakage. This patch corrects the MSR address.
>
> Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
> ---
>
> drivers/video/geode/lxfb.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/geode/lxfb.h b/drivers/video/geode/lxfb.h
> index 6c227f9..ca13c48 100644
> --- a/drivers/video/geode/lxfb.h
> +++ b/drivers/video/geode/lxfb.h
> @@ -33,7 +33,7 @@ void lx_set_palette_reg(struct fb_info *, unsigned int, unsigned int,
>
> #define MSR_LX_GLD_CONFIG 0x48002001
> #define MSR_LX_GLCP_DOTPLL 0x4c000015
> -#define MSR_LX_DF_PADSEL 0x48000011
> +#define MSR_LX_DF_PADSEL 0x48002011
> #define MSR_LX_DC_SPARE 0x80000011
> #define MSR_LX_DF_GLCONFIG 0x48002001
>
Please put MSR indicies in <asm-x86/msr-index.h> and/or a separate
include file.
-hpa
next prev parent reply other threads:[~2007-10-30 0:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 14:53 [PATCH] [LXFB] Use the correct MSR number for panel support Jordan Crouse
2007-10-30 0:02 ` H. Peter Anvin [this message]
2007-10-30 21:33 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472674B0.9080001@zytor.com \
--to=hpa@zytor.com \
--cc=jordan.crouse@amd.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-info@geode.amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tibor.osztodi@bbraun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).