Re: [PATCH] cyber2000fb.c: Fix 16bpp mode

[Woody <woody@suwalski.net>]

Martin Michlmayr wrote:
> Jan Rinze noticed that 16bpp screen mode is not working on Netwinder:
> "After some deduction it appeared that it was running in 24bpp instead
> of 16bpp. Found the bug: a missing 'break' statement at the end of a
> switch case.  After adding the break statement 16bpp works fine."
>
> Signed-off-by: Martin Michlmayr <tbm@cyrius.com>
> Cc: Jan Rinze <janrinze@home.nl>
> Cc: Woody Suwalski <woody@suwalski.net>
>
> --- a/drivers/video/cyber2000fb.c
> +++ b/drivers/video/cyber2000fb.c
> @@ -874,6 +874,8 @@ static int cyber2000fb_set_par(struct fb_info *info)
>  		default:
>  			BUG();
>  		}
> +		break;
> +
>  	case 24:/* TRUECOLOUR, 16m */
>  		hw.co_pixfmt		= CO_PIXFMT_24BPP;
>  		hw.width		*= 3;
>
>   
Yes, with the above bug fix I have tested that 16-bit X fbdev works OK.
Woody


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/