From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94C45C433EF for ; Fri, 4 Feb 2022 17:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235531AbiBDRbs (ORCPT ); Fri, 4 Feb 2022 12:31:48 -0500 Received: from mout.gmx.net ([212.227.15.19]:54581 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234250AbiBDRbs (ORCPT ); Fri, 4 Feb 2022 12:31:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1643995903; bh=K9vYJ4Z0wQ3bmff5arWtA3wK6fAgdN2CVw47Zm1w0tA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=fhgfzqftvaiTA/QXEvDINOcKjkN56pSjouprienVeSM0FFUR/k/e6NjYcJxriV28y CNhFRgkl7xByQstWXX84adL91nOn2Z0JFiKzPMZC0mkkh7fcWZR814HFYMLdWdwde9 o7orK0gyeAKEpkn5i8zEv/Z4RGsTydFo+Y737+CY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.20.60] ([92.116.130.18]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Ml6mE-1mUrAZ02Zg-00lSqW; Fri, 04 Feb 2022 18:31:43 +0100 Message-ID: <47416fc1-bc1d-1a25-2e30-d87e901b336a@gmx.de> Date: Fri, 4 Feb 2022 18:31:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v4 3/3] fbcon: Add option to enable legacy hardware acceleration Content-Language: en-US To: Geert Uytterhoeven Cc: Daniel Vetter , Linux Fbdev development list , DRI Development References: <20220202135531.92183-1-deller@gmx.de> <20220202135531.92183-4-deller@gmx.de> From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:tGtGgjiFkwAzVJSDTfPXM6zaoyGG29VK2i8+grG9iHRBlBukAsr rEA+UCYLwgIgxhJ/WbQrsBNE7QGdxcz/y7MBuDNQvqzu3aSPYYRmS9mc87gGjuPWELASrbW Vpp4AVuL6NLA/coalqCrXOSAhny31c/Nbh9pNUDEFdIdnoxNWW+VaK+X5Sq4NbHDlo0aOhD wNLNVNPGZWUUCG8iDNswA== X-UI-Out-Filterresults: notjunk:1;V03:K0:xOis7iW2H68=:ds4/U5CgZ0KoAx+wwO174G m0HnBR7xERoa3wuHm/nRX13AaC9k8IR+7zHoyIcpJd6fV6KrMtt67Alf02EAb4hsGAoFlV/gX SDzFzFyePjW/w0VuW5KUrJwcAD/2OFCdJHsTCo5qnxExJtnFVfgsX3r8TXtmdwks/BytACk0c ZXa+y8WFVptbXfbUZm7vMEsnfATPhLg2+gZZJBibNlMYLAqNB6hSJ/alNm5L2CYMrjyq/zKeg rffjhXHCnaqRjt5MTeemakiqH0V/tTFhIxCxo2EPVypkvj2AUW3P/kmerXI6QEnb9s7iLBT6T I0bucx2kPslDzplkMc8cbVOhO3VkUZ/Hw4dV1xPQWiLkYUMMrUkb1q87jWcGKr51OwrfkAzIC HiFbIWPZzXR+oi67DuoiLvIj49e1JaMsslYcOXMPDPPUcfrKD574CbOVT9llCn2mY0ODlSvEc T26FAN7uvU4pZxZwqJIX8oc7tmC322ApDeQ2SnKH/xqCwtG7kxnC5urT7bBal1m+6Xw/7bZjI ypZmqQLf2KkdDajQ//OyVrpNyT3h42BceHSEibFkXkbLIpx7ZQuE+J+w+vBa55lMzOtN2Izvu nUUeVlfil8OGaiWdULcm378DK/01tU6Th0RKeJhDE9q+wIOxRI9n+5YUt1oXZF62VmbIiJApp CDzxyxoRWTFRn10QENsBQ/OkPjn1MLVHR08wP26UETo3L5VnAn3Cng4kGhqSWFX++z2cwZpu+ G+e1FUJyJN0ab1v1QBjk21UUtN0XpkiZ2hp3ffFPT978u1tR6I4jWaorRyPp9/OrHFlglaGT5 X7Uc+wECcr2OgyCgAH6tmPrPgUgZmAt0EJRuREeahXDdLKdd2LMv0KZYUaTLIpOnnbVA9enez 6B5I+MssbBjEM2ejrQ1j8nFAY22jvVtvz/SJmdfuTION+QsWDOzKan6g/EAwRQMlO+C09L7/o Fu/1I1zn48lCBrIxOj1n3kmA3n6UKQuUSkJUI3NbPvaMXxbxKoAI1lEibVEwalcfVzNV1lUFD ZWuzRW1PP+QF/9HcLWcHTAc9ZbOfuniODmuTl/WU/QNjb3EagL2dlWoqDGdVoVkYNCcO0mgah lmykPJ6O4Amt9s= Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Geert, On 2/4/22 11:24, Geert Uytterhoeven wrote: > On Fri, Feb 4, 2022 at 11:17 AM Helge Deller wrote: >> On 2/4/22 09:37, Geert Uytterhoeven wrote: >>> On Wed, Feb 2, 2022 at 8:05 PM Helge Deller wrote: >>>> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to >>>> enable bitblt and fillrect hardware acceleration in the framebuffer >>>> console. If disabled, such acceleration will not be used, even if it = is >>>> supported by the graphics hardware driver. >>> >>> Note that this also applies to vertical panning and wrapping. >> >> That's correct. >> Would you mind to send a patch which adds this info? > > To add it where? "bitblt and fillrect" are only mentioned in the patch > description. > > The Kconfig help entry just talks about "hardware acceleration", > which can mean any trick supported by the hardware. Yes, I thought about extending the Kconfig help entry text to mention vertical panning and wrapping as well. If you have an idea how that should be phrased, I think it makes sense to add it. Helge