From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 01 Aug 2017 12:27:03 +0000 Subject: Re: [PATCH] video/mbx: constify fb_fix_screeninfo and fb_var_screeninfo structures Message-Id: <4771229.eUj3tleJI8@amdc3058> List-Id: References: <20170708010956.GA22914@embeddedgus> In-Reply-To: <20170708010956.GA22914@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Friday, July 07, 2017 08:09:56 PM Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct fb_fix_screeninfo i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct fb_fix_screeninfo e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct fb_fix_screeninfo i = { ... }; > > The semantic patch for fb_var_screeninfo is analogous. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics