* [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two funct @ 2017-11-26 13:00 ` SF Markus Elfring 2018-04-26 9:55 ` [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two f Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: SF Markus Elfring @ 2017-11-26 13:00 UTC (permalink / raw) To: linux-fbdev, dri-devel, Arvind Yadav, Bartlomiej Zolnierkiewicz, Geert Uytterhoeven, Kees Cook, Wei Yongjun Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 26 Nov 2017 13:48:55 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c3a46506e47e..0f9b37034eaf 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -2149,10 +2149,8 @@ sh_mobile_lcdc_channel_fb_register(struct sh_mobile_lcdc_chan *ch) if (info->fbdefio) { ch->sglist = vmalloc(sizeof(struct scatterlist) * ch->fb_size >> PAGE_SHIFT); - if (!ch->sglist) { - dev_err(ch->lcdc->dev, "cannot allocate sglist\n"); + if (!ch->sglist) return -ENOMEM; - } } info->bl_dev = ch->bl; @@ -2718,10 +2716,8 @@ static int sh_mobile_lcdc_probe(struct platform_device *pdev) } priv = kzalloc(sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&pdev->dev, "cannot allocate device data\n"); + if (!priv) return -ENOMEM; - } priv->dev = &pdev->dev; priv->meram_dev = pdata->meram_dev; -- 2.15.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two f 2017-11-26 13:00 ` [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two funct SF Markus Elfring @ 2018-04-26 9:55 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2018-04-26 9:55 UTC (permalink / raw) To: SF Markus Elfring Cc: linux-fbdev, Kees Cook, Geert Uytterhoeven, kernel-janitors, LKML, dri-devel, Wei Yongjun, Arvind Yadav On Sunday, November 26, 2017 02:00:16 PM SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 26 Nov 2017 13:48:55 +0100 > > Omit an extra message for a memory allocation failure in these functions. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> I've done requested audit regarding multiple fb devices support myself now and it is okay to apply this patch. Patch queued for 4.18, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-26 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171126130035epcas1p3facfaae6b81c00dc4c9d255e5b8b8bc0@epcas1p3.samsung.com>
2017-11-26 13:00 ` [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two funct SF Markus Elfring
2018-04-26 9:55 ` [PATCH] video: sh_mobile_lcdcfb: Delete an error message for a failed memory allocation in two f Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).