From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, adaplas@gmail.com
Subject: Re: [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs
Date: Tue, 22 Apr 2008 19:43:56 +0400 [thread overview]
Message-ID: <480E07BC.3050107@ru.mvista.com> (raw)
In-Reply-To: <20080422012726.42775DE2A3@ozlabs.org>
Benjamin Herrenschmidt wrote:
> This fixes atyfb to not truncate 64 bits resources on 32 bits
> platforms. Unfortunately, there are still issues with addresses
> returned to userspace via struct fb_fix_screeninfo. This will
> have to be dealt with separately.
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
[...]
> --- linux-work.orig/drivers/video/aty/atyfb_base.c 2008-04-22 11:21:46.000000000 +1000
> +++ linux-work/drivers/video/aty/atyfb_base.c 2008-04-22 11:23:58.000000000 +1000
> @@ -2842,7 +2842,7 @@ static int atyfb_setcolreg(u_int regno,
> #ifdef __sparc__
>
> static int __devinit atyfb_setup_sparc(struct pci_dev *pdev,
> - struct fb_info *info, unsigned long addr)
> + struct fb_info *info, resource_size_t addr)
Not sure what that change gives us -- this function mostly treats 'addr'
as unsigned long (casting it to char/void *), ot compares it to 'unsigned
long' 'base' variable -- which should be made 'resource_size_t' in its turn
being assigned resource's start value. So, this part of patch looks incomplete
(and yet I'm not sure if SPARC really needs all that)...
WBR, Sergei
next prev parent reply other threads:[~2008-04-22 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 1:26 [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs Benjamin Herrenschmidt
2008-04-22 15:43 ` Sergei Shtylyov [this message]
2008-04-22 22:20 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480E07BC.3050107@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).