From: "Krzysztof Helt" <krzysztof.h1@wp.pl>
To: linux-fbdev-devel <linux-fbdev-devel@lists.sourceforge.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] tridentfb: remove misplaced enable_mmio()
Date: Fri, 02 May 2008 11:15:27 +0200 [thread overview]
Message-ID: <481adbafcaaba@wp.pl> (raw)
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
From: Krzysztof Helt <krzysztof.h1@wp.pl>
This patch removes redundant enable_mmio() call as
the mmio mode is enabled in the probe function earlier.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
---
If the patch below is mangled by email client it is also attached.
diff -urp linux-old/drivers/video/tridentfb.c
linux-pc/drivers/video/tridentfb.c
--- linux-old/drivers/video/tridentfb.c 2008-05-01 11:19:02.000000000
+0200
+++ linux-pc/drivers/video/tridentfb.c 2008-05-01 18:06:31.000000000 +0200
@@ -905,7 +905,6 @@ static int tridentfb_set_par(struct fb_i
vblankstart = var->yres;
vblankend = vtotal + 2;
- enable_mmio();
crtc_unlock();
write3CE(CyberControl, 8);
----------------------------------------------------
Kociaki prosto z wybiegów mody?
Ciułała lepsze niż Paris!
http://klik.wp.pl/?adr=http%3A%2F%2Fkonkurs.ulubiency.wp.pl&sid=335
[-- Attachment #2: tridentfb-remove-mmio.diff --]
[-- Type: application/octet-stream, Size: 616 bytes --]
From: Krzysztof Helt <krzysztof.h1@wp.pl>
This patch removes redundant enable_mmio() call as
the mmio mode is enabled in the probe function earlier.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
diff -urp linux-old/drivers/video/tridentfb.c linux-pc/drivers/video/tridentfb.c
--- linux-old/drivers/video/tridentfb.c 2008-05-01 11:19:02.000000000 +0200
+++ linux-pc/drivers/video/tridentfb.c 2008-05-01 18:06:31.000000000 +0200
@@ -905,7 +905,6 @@ static int tridentfb_set_par(struct fb_i
vblankstart = var->yres;
vblankend = vtotal + 2;
- enable_mmio();
crtc_unlock();
write3CE(CyberControl, 8);
[-- Attachment #3: Type: text/plain, Size: 320 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
[-- Attachment #4: Type: text/plain, Size: 182 bytes --]
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
reply other threads:[~2008-05-02 9:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481adbafcaaba@wp.pl \
--to=krzysztof.h1@wp.pl \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).