linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tridentfb: remove misplaced enable_mmio()
@ 2008-05-02  9:15 Krzysztof Helt
  0 siblings, 0 replies; only message in thread
From: Krzysztof Helt @ 2008-05-02  9:15 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

From: Krzysztof Helt <krzysztof.h1@wp.pl>

This patch removes redundant enable_mmio() call as
the mmio mode is enabled in the probe function earlier.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

---

If the patch below is mangled by email client it is also attached.

diff -urp linux-old/drivers/video/tridentfb.c 
linux-pc/drivers/video/tridentfb.c
--- linux-old/drivers/video/tridentfb.c	2008-05-01 11:19:02.000000000 
+0200
+++ linux-pc/drivers/video/tridentfb.c	2008-05-01 18:06:31.000000000 +0200
@@ -905,7 +905,6 @@ static int tridentfb_set_par(struct fb_i
 	vblankstart = var->yres;
 	vblankend = vtotal + 2;
 
-	enable_mmio();
 	crtc_unlock();
 	write3CE(CyberControl, 8);

----------------------------------------------------
Kociaki prosto z wybiegów mody?  
Ciułała lepsze niż Paris! 
http://klik.wp.pl/?adr=http%3A%2F%2Fkonkurs.ulubiency.wp.pl&sid=335

[-- Attachment #2: tridentfb-remove-mmio.diff --]
[-- Type: application/octet-stream, Size: 616 bytes --]

From: Krzysztof Helt <krzysztof.h1@wp.pl>

This patch removes redundant enable_mmio() call as
the mmio mode is enabled in the probe function earlier.

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>

diff -urp linux-old/drivers/video/tridentfb.c linux-pc/drivers/video/tridentfb.c
--- linux-old/drivers/video/tridentfb.c	2008-05-01 11:19:02.000000000 +0200
+++ linux-pc/drivers/video/tridentfb.c	2008-05-01 18:06:31.000000000 +0200
@@ -905,7 +905,6 @@ static int tridentfb_set_par(struct fb_i
 	vblankstart = var->yres;
 	vblankend = vtotal + 2;
 
-	enable_mmio();
 	crtc_unlock();
 	write3CE(CyberControl, 8);
 

[-- Attachment #3: Type: text/plain, Size: 320 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

[-- Attachment #4: Type: text/plain, Size: 182 bytes --]

_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-02  9:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-02  9:15 [PATCH] tridentfb: remove misplaced enable_mmio() Krzysztof Helt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).