From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Mon, 01 Apr 2019 15:46:41 +0000 Subject: Re: [PATCH v2 1/2] video: lcd: Remove useless BACKLIGHT_LCD_SUPPORT kernel symbol Message-Id: <48226922-3534-d1d3-9656-2229b9a04ebb@samsung.com> List-Id: References: <20190117133336.19737-1-shc_work@mail.ru> <20190117161908.4fd2lx62m5soqrff@holly.lan> <20190212084219.GW20638@dell> <1c721088-9bd4-bb88-d6c0-58f73c6f39cc@samsung.com> <64fd6532-83da-333d-279b-748a34428f97@samsung.com> <20190320100708.GM4731@dell> In-Reply-To: <20190320100708.GM4731@dell> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: Daniel Thompson , Alexander Shiyan , Jingoo Han , Linux Fbdev development list , dri-devel On 03/20/2019 11:07 AM, Lee Jones wrote: >>>> On 02/12/2019 09:42 AM, Lee Jones wrote: >>>>> On Fri, 08 Feb 2019, Bartlomiej Zolnierkiewicz wrote: >>>>> >>>>>> >>>>>> On 01/17/2019 05:19 PM, Daniel Thompson wrote: >>>>>>> On Thu, Jan 17, 2019 at 04:33:35PM +0300, Alexander Shiyan wrote: >>>>>>>> We have two *_CLASS_DEVICE kernel config options (LCD_CLASS_DEVICE >>>>>>>> and BACKLIGHT_LCD_DEVICE) that do the same job. >>>>>>>> The patch removes useless BACKLIGHT_LCD_SUPPORT option >>>>>>>> and converts LCD_CLASS_DEVICE into a menu. >>>>>>>> >>>>>>>> Signed-off-by: Alexander Shiyan >>>>>>> >>>>>>> A cover letter with the v1 -> v2 changelog would be nice... but >>>>>>> nevertheless: >>>>>>> Acked-by: Daniel Thompson >>>>>> >>>>>> Also: >>>>>> >>>>>> Acked-by: Bartlomiej Zolnierkiewicz >>>>>> >>>>>> Lee, will you pick this up or do you want me to do it? >>>>> >>>>> You can take them if you want. I will require a pull-request from an >>>>> independent immutable branch though please. >>>> >>>> OK, immutable branch will also allow other trees (drm) to sync with >>>> these changes if desired. >>>> >>>> I will do it for v5.2 if you are fine with it (too late for v5.1 >>>> IMHO and I also won't have time too fix any potential issues next >>>> week). > >>> Topic branch for these 2 simple patches seems like serious overkill. > > [...] > >>> Would be good to get it into 5.1 still though, just to avoid too >>> many conflicts. > > I think you just answered your own statement. :) > >> Well, if so I'm also fine with this going in 5.1 w/o topic branch. >> >> Lee, do you want to merge this directly into backlight tree (you >> have now both fbdev and drm acks)? > > It was too late for v5.1. > > Do you still want to take this for v5.2, or should I take them and > provide you with an immutable pull-request? Please take them and provide immutable branch, thank you. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics