Re: [RFC 2.6.26-rc3 1/7] pxafb: module unloading support

[Eric Miao <eric.y.miao@gmail.com>]

Krzysztof Helt wrote:
> On Wed, 11 Jun 2008 21:36:04 -0700
> "Jaya Kumar" <jayakumar.lkml@gmail.com> wrote:
> 
>> On Tue, Jun 10, 2008 at 12:44 AM, Eric Miao <eric.y.miao@gmail.com> wrote:
>>> Lothar Waßmann wrote:
>>>> Jaya Kumar wrote:
>>>>> @@ -1587,7 +1587,7 @@ static int __init pxafb_parse_options(struct device *dev, char *options)
>>>>>  static char g_options[256] __devinitdata = "";
>>>>>
>>>>>  #ifndef CONFIG_MODULES
>>>>            ^^^^^^^^^^^^^^
>>>>> -static int __devinit pxafb_setup_options(void)
>>>>> +static int __init pxafb_setup_options(void)
>>>>>
>>>> That should be '#ifndef MODULE'.
>>>> Otherwise support for cmdline options for the built-in driver will
>>>> only be enabled if the kernel is compiled without module support.
>>>>
>>> Yes, indeed. It requires another fix patch for this.
>>>
>> Hi Eric, Lothar,
>>
>> That CONFIG_MODULES is from the pxafb code. It is not part of the
>> changes that I made to pxafb.
>>
> 
> I support Jaya position on this. The offending line is not part of his
> patch. I think that this set of patches can be accepted with additional
> patch which corrects existing pxafb problems (not related to his changes).
> He may even post this patch before his set if this is required this way.
> 

OK, I see. I'm not proposing a quick fix patch for the moment.

I still feel a bit upset to this set of patches, and I need more time
to review, thanks.

> Regards,
> Krzysztof
> 
> 
> ----------------------------------------------------------------------
> Podbij Dziki Zachod!Gra strategiczna online
> Sprawdz >>> http://link.interia.pl/f1dff
> 


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel