Re: [RFC 2.6.26-rc3 04/10] pxafb: add exit and remove handlers

[Eric Miao <eric.y.miao@gmail.com>]

Jaya Kumar wrote:
> This patch adds exit and remove handlers to pxafb so that it can be loaded
> and unloaded as a module.
> 
> Signed-off-by: Jaya Kumar <jayakumar.lkml@gmail.com>

Acked-by: Eric Miao <eric.miao@marvell.com>

> ---
>  drivers/video/pxafb.c |   44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 44 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c
> index b891aac..89f1b48 100644
> --- a/drivers/video/pxafb.c
> +++ b/drivers/video/pxafb.c
> @@ -1790,11 +1790,49 @@ failed:
>  	return ret;
>  }
>  
> +static int __devexit pxafb_remove(struct platform_device *dev)
> +{
> +	struct pxafb_info *fbi = platform_get_drvdata(dev);
> +	struct resource *r;
> +	int irq;
> +	struct fb_info *info;
> +
> +	if (!fbi)
> +		return 0;
> +
> +	info = &fbi->fb;
> +
> +	unregister_framebuffer(info);
> +
> +	pxafb_disable_controller(fbi);
> +
> +	if (fbi->fb.cmap.len)
> +		fb_dealloc_cmap(&fbi->fb.cmap);
> +
> +	irq = platform_get_irq(dev, 0);
> +	free_irq(irq, fbi);
> +
> +	dma_free_writecombine(&dev->dev, fbi->map_size,
> +					fbi->map_cpu, fbi->map_dma);
> +
> +	iounmap(fbi->mmio_base);
> +
> +	r = platform_get_resource(dev, IORESOURCE_MEM, 0);
> +	release_mem_region(r->start, r->end - r->start + 1);
> +
> +	clk_put(fbi->clk);
> +	kfree(fbi);
> +
> +	return 0;
> +}
> +
>  static struct platform_driver pxafb_driver = {
>  	.probe		= pxafb_probe,
> +	.remove 	= pxafb_remove,
>  	.suspend	= pxafb_suspend,
>  	.resume		= pxafb_resume,
>  	.driver		= {
> +		.owner	= THIS_MODULE,
>  		.name	= "pxa2xx-fb",
>  	},
>  };
> @@ -1807,7 +1845,13 @@ static int __init pxafb_init(void)
>  	return platform_driver_register(&pxafb_driver);
>  }
>  
> +static void __exit pxafb_exit(void)
> +{
> +	platform_driver_unregister(&pxafb_driver);
> +}
> +
>  module_init(pxafb_init);
> +module_exit(pxafb_exit);
>  
>  MODULE_DESCRIPTION("loadable framebuffer driver for PXA");
>  MODULE_LICENSE("GPL");


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php