From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Miao Subject: Re: [RFC 2.6.26-rc3 07/10] am200epd: move am200epd to mach-pxa Date: Fri, 13 Jun 2008 10:12:17 +0800 Message-ID: <4851D781.9020007@gmail.com> References: <1213289961-1562-1-git-send-email-jayakumar.lkml@gmail.com> <1213289961-1562-8-git-send-email-jayakumar.lkml@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1K6ymC-0004AY-A7 for linux-fbdev-devel@lists.sourceforge.net; Thu, 12 Jun 2008 19:12:28 -0700 Received: from ti-out-0910.google.com ([209.85.142.191]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1K6ym9-0006go-0Z for linux-fbdev-devel@lists.sourceforge.net; Thu, 12 Jun 2008 19:12:28 -0700 Received: by ti-out-0910.google.com with SMTP id y6so1401627tia.18 for ; Thu, 12 Jun 2008 19:12:24 -0700 (PDT) In-Reply-To: <1213289961-1562-8-git-send-email-jayakumar.lkml@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: Jaya Kumar Cc: ymiao3@marvell.com, linux-fbdev-devel@lists.sourceforge.net, linux-arm-kernel@lists.arm.linux.org.uk Jaya Kumar wrote: > The am200epd driver was designed with bad assumptions. It manipulated > GPSR/GPLR registers directly. It relied on direct access to the pxa LCDC > registers which have since conflicted with commit > ce4fb7b892a6d6c6a0f87366b26fd834d2923dd7 . This patch moves it into > mach-pxa in preparation for an overhaul. This is done as a move rather > than a removal in order to facilitate code review. You may generate the patch with "-M" option, so that git can recognize the file rename/move change. Also, I think it would be better to merge this commit with your following [patch 08] am200epd: conver to share fb and use gpio api, that will be helpful for code review, and "-M" option should be smart enough to make the change clear. > > Signed-off-by: Jaya Kumar > --- > arch/arm/mach-pxa/Kconfig | 17 +++ > arch/arm/mach-pxa/Makefile | 1 + > arch/arm/mach-pxa/am200epd.c | 295 ++++++++++++++++++++++++++++++++++++++++++ > drivers/video/Kconfig | 13 -- > drivers/video/Makefile | 1 - > drivers/video/am200epd.c | 295 ------------------------------------------ > 6 files changed, 313 insertions(+), 309 deletions(-) > create mode 100644 arch/arm/mach-pxa/am200epd.c > delete mode 100644 drivers/video/am200epd.c > > diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig > index 5da7a68..1bcff21 100644 > --- a/arch/arm/mach-pxa/Kconfig > +++ b/arch/arm/mach-pxa/Kconfig > @@ -179,6 +179,23 @@ endchoice > > endif > > +if MACH_GUMSTIX_F > + > +choice > + prompt "Select base board for Gumstix board" > + > +config MACH_AM200EPD > + tristate "Enable AM200EPD board support" > + select FB_METRONOME > + select FB_SYS_FILLRECT > + select FB_SYS_COPYAREA > + select FB_SYS_IMAGEBLIT > + select FB_SYS_FOPS > + select FB_DEFERRED_IO > + > +endchoice > + > +endif > > if MACH_TRIZEPS4 > > diff --git a/arch/arm/mach-pxa/Makefile b/arch/arm/mach-pxa/Makefile > index 0e6d05b..c72db62 100644 > --- a/arch/arm/mach-pxa/Makefile > +++ b/arch/arm/mach-pxa/Makefile > @@ -20,6 +20,7 @@ obj-$(CONFIG_CPU_PXA320) += pxa320.o > > # Specific board support > obj-$(CONFIG_ARCH_GUMSTIX) += gumstix.o > +obj-$(CONFIG_MACH_AM200EPD) += am200epd.o > obj-$(CONFIG_ARCH_LUBBOCK) += lubbock.o > obj-$(CONFIG_MACH_LOGICPD_PXA270) += lpd270.o > obj-$(CONFIG_MACH_MAINSTONE) += mainstone.o > diff --git a/arch/arm/mach-pxa/am200epd.c b/arch/arm/mach-pxa/am200epd.c > new file mode 100644 > index 0000000..51e26c1 > --- /dev/null > +++ b/arch/arm/mach-pxa/am200epd.c > @@ -0,0 +1,295 @@ > +/* > + * linux/drivers/video/am200epd.c -- Platform device for AM200 EPD kit > + * > + * Copyright (C) 2008, Jaya Kumar > + * > + * This file is subject to the terms and conditions of the GNU General Public > + * License. See the file COPYING in the main directory of this archive for > + * more details. > + * > + * Layout is based on skeletonfb.c by James Simmons and Geert Uytterhoeven. > + * > + * This work was made possible by help and equipment support from E-Ink > + * Corporation. http://support.eink.com/community > + * > + * This driver is written to be used with the Metronome display controller. > + * on the AM200 EPD prototype kit/development kit with an E-Ink 800x600 > + * Vizplex EPD on a Gumstix board using the Lyre interface board. > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include