From: Jiri Slaby <jirislaby@gmail.com>
To: JosephChan@via.com.tw
Cc: geert@linux-m68k.org, akpm@linux-foundation.org,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/13] viafb: hw.c, hw.h
Date: Mon, 30 Jun 2008 09:32:38 +0200 [thread overview]
Message-ID: <48688C16.5040405@gmail.com> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB8074E77AC@exchtp03.taipei.via.com.tw>
On 06/30/2008 09:04 AM, JosephChan@via.com.tw wrote:
> Display hw setting and other chips initialization.
>
>
> Signed-off-by: Joseph Chan <josephchan@via.com.tw>
>
> diff -Nur a/drivers/video/via/hw.c b/drivers/video/via/hw.c
> --- a/drivers/video/via/hw.c 1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/hw.c 2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,2865 @@
[...]
> +#include "global.h"
> +
> +static const struct pci_device_id_info pciidlist[] = {
> + {PCI_VIA_VENDOR_ID, UNICHROME_CLE266_DID, UNICHROME_CLE266},
> + {PCI_VIA_VENDOR_ID, UNICHROME_PM800_DID, UNICHROME_PM800},
> + {PCI_VIA_VENDOR_ID, UNICHROME_K400_DID, UNICHROME_K400},
> + {PCI_VIA_VENDOR_ID, UNICHROME_K800_DID, UNICHROME_K800},
> + {PCI_VIA_VENDOR_ID, UNICHROME_CN700_DID, UNICHROME_CN700},
> + {PCI_VIA_VENDOR_ID, UNICHROME_P4M890_DID, UNICHROME_P4M890},
> + {PCI_VIA_VENDOR_ID, UNICHROME_K8M890_DID, UNICHROME_K8M890},
> + {PCI_VIA_VENDOR_ID, UNICHROME_CX700_DID, UNICHROME_CX700},
> + {PCI_VIA_VENDOR_ID, UNICHROME_P4M900_DID, UNICHROME_P4M900},
> + {PCI_VIA_VENDOR_ID, UNICHROME_CN750_DID, UNICHROME_CN750},
> + {PCI_VIA_VENDOR_ID, UNICHROME_VX800_DID, UNICHROME_VX800},
> + {0, 0, 0}
> +};
Why do you need yet another pci_device_id? How do you insure autoloading?
> +
> +struct offset offset_reg = {
> + /* IGA1 Offset Register */
> + {IGA1_OFFSET_REG_NUM, {{CR13, 0, 7}, {CR35, 5, 7} } },
> + /* IGA2 Offset Register */
> + {IGA2_OFFSET_REG_NUM, {{CR66, 0, 7}, {CR67, 0, 1} } }
> +};
> +
> +struct pll_map pll_value[] = {
May this be static const (and all of these)?
> + {CLK_25_175M, CLE266_PLL_25_175M, K800_PLL_25_175M, CX700_25_175M},
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
next prev parent reply other threads:[~2008-06-30 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 7:04 [PATCH 6/13] viafb: hw.c, hw.h JosephChan
2008-06-30 7:32 ` Jiri Slaby [this message]
2008-08-08 10:14 ` [PATCH 6/13 v2] " JosephChan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48688C16.5040405@gmail.com \
--to=jirislaby@gmail.com \
--cc=JosephChan@via.com.tw \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).