Re: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h

[Jiri Slaby <jirislaby@gmail.com>]

> diff -Nur a/drivers/video/via/ioctl.h b/drivers/video/via/ioctl.h
> --- a/drivers/video/via/ioctl.h	1970-01-01 08:00:00.000000000 +0800
> +++ b/drivers/video/via/ioctl.h	2008-06-30 08:53:33.000000000 +0800
> @@ -0,0 +1,212 @@
[...]
> +struct device_t {
> +	unsigned short crt:1;
> +	unsigned short dvi:1;
> +	unsigned short lcd:1;
> +	unsigned short samm:1;
> +	unsigned short primary_dev;
> +
> +	unsigned short lcd_dsp_cent:1;
> +	unsigned char lcd_panel_id;
> +	unsigned char lcd_mode:1;
> +
> +	unsigned short xres, yres;
> +	unsigned short xres1, yres1;
> +	unsigned short refresh;
> +	unsigned short bpp;
> +	unsigned short refresh1;
> +	unsigned short bpp1;
> +	unsigned short sequence;
> +
> +	unsigned short epia_dvi:1;
> +	unsigned short lcd_dual_edge:1;
> +	unsigned short bus_width;
> +	unsigned short lcd2:1;
> +};

Bitfields suck (and generate ugly code).

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php