Re: [PATCH] Add fb_check_var() for fixed mode device.

[Helge Deller <deller@gmx.de>]

Helge Deller wrote:
> The attached patch is a completely different approach to solve the 
> issue. I've tested it, and it works even with the buggy version of X 
> (1.4.2).
> 
> Basic idea is, that when we have fixed mode devices (aka drivers which 
> don't implement fb_check_var) we just simply fill in a "emulated" valid 
> monitor/modeline into the var struct during the register_framebuffer() 
> initialization call. Since the modeline is valid, X does not has any 
> problems with it.
> 
> The patch has a few benefits:
> a) We still keep binary compatability/behavior for FBIOGET_VSCREENINFO 
> and FBIOPUT_VSCREENINFO.
> b) In Xorg.conf files, users can simply delete all monitor and display 
> sections -> Xorg will autoconfigure itself to the only valid 
> resolution/modeline itself on all devices (I really like this!!!)
> 
> Thus, the patch basically changes the fixed mode drivers to have some 
> monitor timings by default. As an example, before I got:
> root@c3000:~# fbset -i
> mode "1024x768"
>     geometry 1024 768 1024 768 8
>     timings 0 0 0 0 0 0 0
>     rgba 8/0,8/0,8/0,0/0
> endmode
> 
> Now I see:
> root@c3000:~# fbset -i
> mode "1024x768-60"
>     # D: 65.003 MHz, H: 48.365 kHz, V: 60.006 Hz
>     geometry 1024 768 1024 768 8
>     timings 15384 168 8 29 3 144 6
>     rgba 8/0,8/0,8/0,0/0
> endmode
> 
> Opinions ?

Sadly nobody answered yet....

Helge

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/