From: Ian Molton <spyro@f2s.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
Samuel Ortiz <sameo@openedhand.com>,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [RESEND][PATCH 1/2] fbdev: add new TMIO framebuffer driver
Date: Fri, 03 Oct 2008 12:35:53 +0100 [thread overview]
Message-ID: <48E60399.4010302@f2s.com> (raw)
In-Reply-To: <20081003022323.a523a510.akpm@linux-foundation.org>
Andrew Morton wrote:
> I realise it isn't your code, but these:
>
> #define tmio_ioread32(addr) \
...are my fault. Sorry about that.
> As is so often the case, these never needed to be implemented as macros
> and hence should not have been. C is better.
Good point, well made. I'm happy for them to be changed to inline
functions. They grew out of the MMC code, where they were used to clean
up the IO transfer loops. I'll send a patch to Samuel for his MFD tree
to effect this change.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
next prev parent reply other threads:[~2008-10-03 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 8:38 [RESEND][PATCH 1/2] fbdev: add new TMIO framebuffer driver Dmitry Baryshkov
2008-09-30 8:38 ` [RESEND][PATCH 2/2] mfd: support tmiofb cell on tc6393xb Dmitry Baryshkov
2008-10-03 22:56 ` Samuel Ortiz
2008-09-30 9:17 ` [RESEND][PATCH 1/2] fbdev: add new TMIO framebuffer driver Geert Uytterhoeven
2008-09-30 14:37 ` Ian Molton
2008-09-30 22:04 ` Krzysztof Helt
2008-10-04 13:38 ` Dmitry
2008-10-03 9:23 ` Andrew Morton
2008-10-03 11:35 ` Ian Molton [this message]
2008-10-04 21:41 ` Dmitry
2008-10-04 21:58 ` Andrew Morton
2008-10-05 8:09 ` Dmitry
-- strict thread matches above, loose matches on Subject: below --
2008-09-30 9:11 krzysztof.h1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E60399.4010302@f2s.com \
--to=spyro@f2s.com \
--cc=akpm@linux-foundation.org \
--cc=dbaryshkov@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).