[PATCH] framebuffer: fix carminefb section mismatch

[PATCH] framebuffer: fix carminefb section mismatch

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Could fix a dangerous problem since
	info->fix = carminefb_fix;
and info->fix can be used at any time later (in carmine_set_par()).

WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix
The function alloc_carmine_fb() references
the variable __devinitdata carminefb_fix.
This is often because alloc_carmine_fb lacks a __devinitdata 
annotation or the annotation of carminefb_fix is wrong.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Sebastian Siewior <bigeasy@linutronix.de>
---
 drivers/video/carminefb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lin2627-r9g1-sections.orig/drivers/video/carminefb.c
+++ lin2627-r9g1-sections/drivers/video/carminefb.c
@@ -76,7 +76,7 @@ struct carmine_fb {
 	u32 pseudo_palette[16];
 };
 
-static struct fb_fix_screeninfo carminefb_fix __devinitdata = {
+static struct fb_fix_screeninfo carminefb_fix = {
 	.id = "Carmine",
 	.type = FB_TYPE_PACKED_PIXELS,
 	.visual = FB_VISUAL_TRUECOLOR,

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [PATCH] framebuffer: fix carminefb section mismatch

[Geert Uytterhoeven]

On Wed, 8 Oct 2008, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Could fix a dangerous problem since
> 	info->fix = carminefb_fix;
> and info->fix can be used at any time later (in carmine_set_par()).

This is a full copy of the contents, not a pointer to the original.

> WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix
> The function alloc_carmine_fb() references
> the variable __devinitdata carminefb_fix.
> This is often because alloc_carmine_fb lacks a __devinitdata 
> annotation or the annotation of carminefb_fix is wrong.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Sebastian Siewior <bigeasy@linutronix.de>
> ---
>  drivers/video/carminefb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lin2627-r9g1-sections.orig/drivers/video/carminefb.c
> +++ lin2627-r9g1-sections/drivers/video/carminefb.c
> @@ -76,7 +76,7 @@ struct carmine_fb {
>  	u32 pseudo_palette[16];
>  };
>  
> -static struct fb_fix_screeninfo carminefb_fix __devinitdata = {
> +static struct fb_fix_screeninfo carminefb_fix = {
>  	.id = "Carmine",
>  	.type = FB_TYPE_PACKED_PIXELS,
>  	.visual = FB_VISUAL_TRUECOLOR,

alloc_carmine_fb() should be __devinit instead?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [PATCH] framebuffer: fix carminefb section mismatch

[Randy Dunlap]

Geert Uytterhoeven wrote:
> On Wed, 8 Oct 2008, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Could fix a dangerous problem since
>> 	info->fix = carminefb_fix;
>> and info->fix can be used at any time later (in carmine_set_par()).
> 
> This is a full copy of the contents, not a pointer to the original.

Argh, darn it.  Thanks.

>> WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix
>> The function alloc_carmine_fb() references
>> the variable __devinitdata carminefb_fix.
>> This is often because alloc_carmine_fb lacks a __devinitdata 
>> annotation or the annotation of carminefb_fix is wrong.
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> cc: Sebastian Siewior <bigeasy@linutronix.de>
>> ---
>>  drivers/video/carminefb.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lin2627-r9g1-sections.orig/drivers/video/carminefb.c
>> +++ lin2627-r9g1-sections/drivers/video/carminefb.c
>> @@ -76,7 +76,7 @@ struct carmine_fb {
>>  	u32 pseudo_palette[16];
>>  };
>>  
>> -static struct fb_fix_screeninfo carminefb_fix __devinitdata = {
>> +static struct fb_fix_screeninfo carminefb_fix = {
>>  	.id = "Carmine",
>>  	.type = FB_TYPE_PACKED_PIXELS,
>>  	.visual = FB_VISUAL_TRUECOLOR,
> 
> alloc_carmine_fb() should be __devinit instead?

I'll check on that.

Thanks again for checking.
-- 
~Randy

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

[PATCH v2] framebuffer: fix carminefb section mismatch

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Make alloc_carmine_fb() __devinit.

WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix
The function alloc_carmine_fb() references
the variable __devinitdata carminefb_fix.
This is often because alloc_carmine_fb lacks a __devinitdata 
annotation or the annotation of carminefb_fix is wrong.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Sebastian Siewior <bigeasy@linutronix.de>
---
 drivers/video/carminefb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lin2627-r9g1-sections.orig/drivers/video/carminefb.c
+++ lin2627-r9g1-sections/drivers/video/carminefb.c
@@ -535,7 +535,7 @@ static struct fb_ops carminefb_ops = {
 	.fb_setcolreg	= carmine_setcolreg,
 };
 
-static int alloc_carmine_fb(void __iomem *regs, void __iomem *smem_base,
+static int __devinit alloc_carmine_fb(void __iomem *regs, void __iomem *smem_base,
 		int smem_offset, struct device *device, struct fb_info **rinfo)
 {
 	int ret;

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

Re: [PATCH v2] framebuffer: fix carminefb section mismatch

[Sebastian Andrzej Siewior]

Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Make alloc_carmine_fb() __devinit.
> 
> WARNING: drivers/video/carminefb.o(.text+0x81b): Section mismatch in reference from the function alloc_carmine_fb() to the variable .devinit.data:carminefb_fix
> The function alloc_carmine_fb() references
> the variable __devinitdata carminefb_fix.
> This is often because alloc_carmine_fb lacks a __devinitdata 
> annotation or the annotation of carminefb_fix is wrong.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Sebastian Siewior <bigeasy@linutronix.de>
Thx for the patch Randy. I see Andrew slipped it allready in his queue.

Sebastian

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/