From: roel kluin <roel.kluin@gmail.com>
To: nicolas.ferre@atmel.com, linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] atmel_lcdfb: unsigned irq_base cannot be negative
Date: Mon, 20 Oct 2008 23:41:50 -0400 [thread overview]
Message-ID: <48FD4F7E.6010708@gmail.com> (raw)
unsigned irq_base cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index f8d0a57..f93f57a 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -857,12 +857,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
goto stop_clk;
}
- sinfo->irq_base = platform_get_irq(pdev, 0);
- if (sinfo->irq_base < 0) {
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0) {
dev_err(dev, "unable to get irq\n");
- ret = sinfo->irq_base;
goto stop_clk;
}
+ sinfo->irq_base = ret;
/* Initialize video memory */
map = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
next reply other threads:[~2008-10-20 23:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 3:41 roel kluin [this message]
2008-10-21 8:46 ` [PATCH] atmel_lcdfb: unsigned irq_base cannot be negative Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD4F7E.6010708@gmail.com \
--to=roel.kluin@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).