From: "Robert T. Drury" <rtdrury@earthlink.net>
To: linux-fbdev-devel@lists.sourceforge.net,
benh@kernel.crashing.org, akpm@linux-foundation.org
Subject: [PATCH] fix: radeon backlight shutoff flashes momentarily
Date: Wed, 11 Mar 2009 04:53:25 -0700 [thread overview]
Message-ID: <49B7A635.1020409@earthlink.net> (raw)
aluminum powerbook G4 with radeon
The backlight momentarily flashes brightly when turning off.
If the backlight is originally dim, the flash is more noticeable.
This momentary flash is stressful on the power circuit.
The first OUTREG to LVDS_GEN_CNTL causes the flashing problem.
To fix, remove the first manipulation of lvds_gen_cntl above it.
Second manipulation of lvds_gen_cntl does nothing (level always zero).
The first manipulation was needed so the display would not be
garbled after turning the backlight back on, but at least on my powerbook,
the garbling seems to go away when the udelay is 1000.
bugzilla[Bug 12845]
Signed-off-by: Robert Drury <rtdrury@earthlink.net>
--- linux-2.6.23.9/drivers/video/aty/radeon_backlight.c.orig 2009-03-11 01:57:10.000000000 -0700
+++ linux-2.6.23.9/drivers/video/aty/radeon_backlight.c 2009-03-11 02:26:28.000000000 -0700
@@ -101,12 +101,9 @@ static int radeon_bl_update_status(struc
tmpPixclksCntl = INPLL(PIXCLKS_CNTL);
if (rinfo->is_mobility || rinfo->is_IGP)
OUTPLLP(PIXCLKS_CNTL, 0, ~PIXCLK_LVDS_ALWAYS_ONb);
- lvds_gen_cntl &= ~(LVDS_BL_MOD_LEVEL_MASK | LVDS_BL_MOD_EN);
- lvds_gen_cntl |= (radeon_bl_get_level_brightness(pdata, 0) <<
- LVDS_BL_MOD_LEVEL_SHIFT);
lvds_gen_cntl |= LVDS_DISPLAY_DIS;
OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
- udelay(100);
+ udelay(1000);
lvds_gen_cntl &= ~(LVDS_ON | LVDS_EN);
OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
lvds_gen_cntl &= ~(LVDS_DIGON);
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
reply other threads:[~2009-03-11 11:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B7A635.1020409@earthlink.net \
--to=rtdrury@earthlink.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).